Skip to content

chore: update createOrder callback comment and example payload#21

Merged
gregjopa merged 1 commit into
mainfrom
update-create-order-strategy
Feb 1, 2023
Merged

chore: update createOrder callback comment and example payload#21
gregjopa merged 1 commit into
mainfrom
update-create-order-strategy

Conversation

@gregjopa
Copy link
Copy Markdown
Contributor

@gregjopa gregjopa commented Jan 31, 2023

This PR updates the createOrder() callback comment to better describe what safe order information we should pass from the browser to the server.

@gregjopa gregjopa requested a review from westeezy January 31, 2023 22:51
Copy link
Copy Markdown

@westeezy westeezy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@westeezy westeezy requested a review from sioked January 31, 2023 23:27
@gregjopa gregjopa merged commit 55a452b into main Feb 1, 2023
@gregjopa gregjopa deleted the update-create-order-strategy branch February 1, 2023 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants