Use harmonia-store-core to save on a lot of code#45
Merged
Ericson2314 merged 1 commit intopdtpartners:mainfrom Mar 12, 2026
Merged
Use harmonia-store-core to save on a lot of code#45Ericson2314 merged 1 commit intopdtpartners:mainfrom
harmonia-store-core to save on a lot of code#45Ericson2314 merged 1 commit intopdtpartners:mainfrom
Conversation
We can get rid of nix-libstore this way. The old nix-libstore and harmonia-store-core store path types differently, so this required a fair bit of plumbing of the store path. As part of this, fix NixOS test failures. Putting packages in environment.systemPackages isn't correct, it should be done with nix.package. This happened to work with older nix, but doesn't anymore. Co-authored-by: Artemis Tosini <artemis.tosini@obsidian.systems> Co-authored-by: Amaan Qureshi <git@amaanq.com>
Ericson2314
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We can get rid of
nix-libstorethis way.The old nix-libstore and harmonia-store-core store path types differently, so this required a fair bit of plumbing of the store path.
As part of this, fix NixOS test failures.
Putting packages in
environment.systemPackagesisn't correct, it should be done withnix.package. This happened to work with older nix, but doesn't anymore.This is a continuation of #40