Update custom corepc branch to support bitcoind v31.0 download (and remove manual download from CI) - #435
Merged
Merged
Conversation
0xB10C
marked this pull request as draft
May 20, 2026 09:05
0xB10C
force-pushed
the
2026-05-update-custom-corepc
branch
from
May 20, 2026 09:27
f352385 to
e4ad399
Compare
Not needed anymore with corepc's bitcoind v31 download.
0xB10C
force-pushed
the
2026-05-update-custom-corepc
branch
from
May 20, 2026 09:38
e4ad399 to
cb117b8
Compare
0xB10C
marked this pull request as ready for review
May 20, 2026 09:38
Collaborator
Author
|
@xyzconstant do you want to have a look at this? |
6 tasks
xyzconstant
approved these changes
May 20, 2026
xyzconstant
left a comment
xyzconstant
left a comment
Collaborator
There was a problem hiding this comment.
Seems good to me, I've tested exactly these changes before but using my corepc fork instead.
ACK cb117b8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a followup to #379, which added a workaround to manually fetch Bitcoin Core for the Ubuntu CI as it wasn't avaliable in corepc yet. I've pushed a commit (0xB10C/corepc@3ceda10) to the custom corepc branch we maintain anyway to be able to download it. Upgrading to this commit here allows us to drop the manual download.
We can drop this the next time we update to a newer corepc release with this merged.