fix(predicate): Fix address related layers detection - #1317
Merged
Conversation
orangejulius
force-pushed
the
fix-address-related-queries
branch
from
June 17, 2019 21:05
53cbfd5 to
8688d8f
Compare
missinglink
approved these changes
Jun 18, 2019
missinglink
left a comment
missinglink
left a comment
Member
There was a problem hiding this comment.
The code looks fine, I don't think I have a deep enough understanding of this to give any feedback on its intended function.
Member
Author
|
@missinglink the code is a bit confusing, and takes a bit of reading through to grasp. Fundamentally, the issue this PR (and the previous PR) intend to fix is as follows: Take any address input with an admin area, and append |
This fixes an error in the logic from #1307. The `address_search_with_ids` query can only return results in the address or street layers. However, the predicate logic was allowing the query to execute if _any_ admin layer was specified, which could allow such a query to return street or address layers when not intended.
orangejulius
force-pushed
the
fix-address-related-queries
branch
from
June 18, 2019 13:08
8688d8f to
3a05567
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an error in the logic from #1307.
The
address_search_with_idsquery can only return results in the address or street layers. Admin results would come from a previous query to the Placeholder service.However, the predicate logic was allowing the query to execute if an admin layer was specified, which could result in the API returning results from the street or address layers when not intended.