add support of mixed-type array#376
Conversation
Codecov Report
@@ Coverage Diff @@
## master #376 +/- ##
==========================================
- Coverage 95.54% 95.24% -0.30%
==========================================
Files 10 10
Lines 2288 2313 +25
==========================================
+ Hits 2186 2203 +17
- Misses 65 70 +5
- Partials 37 40 +3
Continue to review full report at Codecov.
|
|
Thank you for taking care of this, I apologize for the delay in review. I think the PR could use a test for the new check in |
|
I think if mtype.Elem().Kind() == reflect.Interface {
return nil, fmt.Errorf("marshal can't handle []interface{}")
}I delete these lines to support |
|
Ha my bad, looks like I misread the diff. All good, thank you for calling this out! |
Issue: #357
This pr adds support of mixed-type array as the spec(v1.0.0) describes: