Skip to content

fix for try-runtime features#386

Merged
gianfra-t merged 6 commits into
mainfrom
compile-with-try-runtime
Jan 12, 2024
Merged

fix for try-runtime features#386
gianfra-t merged 6 commits into
mainfrom
compile-with-try-runtime

Conversation

@gianfra-t
Copy link
Copy Markdown
Contributor

@gianfra-t gianfra-t commented Dec 29, 2023

This PR adds fixes so that the runtimes can be compiled with the try-runtime feature. Also should solve #327.
Related to tasks/#64 and the upgrade to 0.9.42. I believe it would be a good idea to first have the capability of testing with try-runtime the upgrade.

This PR also has a small fix regarding this comment

@gianfra-t gianfra-t marked this pull request as draft December 29, 2023 19:41
@ebma
Copy link
Copy Markdown
Member

ebma commented Jan 10, 2024

Would you say this is related to #327 then?

@gianfra-t
Copy link
Copy Markdown
Contributor Author

Yes! I wasn't aware about that issue. Adding it to the description.

@TorstenStueber
Copy link
Copy Markdown
Contributor

@gianfra-t since the ticket you mention in your ticket above has been closed, can we open this PR here for review or is it still a draft?

@gianfra-t
Copy link
Copy Markdown
Contributor Author

I'm right now merging with main and checking that everything still works.

@gianfra-t gianfra-t marked this pull request as ready for review January 10, 2024 20:06
@gianfra-t gianfra-t requested a review from a team January 10, 2024 22:17
Copy link
Copy Markdown
Contributor

@TorstenStueber TorstenStueber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is also a Spacewalk dependency in pallets/orml-tokens-management-extension/Cargo.toml and in runtime/integration-tests/Cargo.toml, which should probably also be updated (?)

Comment thread runtime/development/src/lib.rs Outdated
Comment thread runtime/common/src/lib.rs Outdated
@gianfra-t
Copy link
Copy Markdown
Contributor Author

There is also a Spacewalk dependency in pallets/orml-tokens-management-extension/Cargo.toml and in runtime/integration-tests/Cargo.toml, which should probably also be updated (?)

Thanks for finding this. It mus have been a reference to an even older commit, not sure how it was compiling!

Copy link
Copy Markdown
Contributor

@TorstenStueber TorstenStueber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks all good to me now.

@TorstenStueber
Copy link
Copy Markdown
Contributor

However, would be good to also get @ebma's opinion here as he commented here on the changes with the RelativeValue.

Copy link
Copy Markdown
Member

@ebma ebma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread runtime/pendulum/Cargo.toml Outdated
@gianfra-t gianfra-t force-pushed the compile-with-try-runtime branch from 847119e to 144d01e Compare January 12, 2024 13:30
@gianfra-t gianfra-t force-pushed the compile-with-try-runtime branch from 144d01e to 37de4e6 Compare January 12, 2024 13:31
@gianfra-t gianfra-t merged commit 89b6264 into main Jan 12, 2024
@gianfra-t gianfra-t deleted the compile-with-try-runtime branch January 12, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants