Fix type safety and error handling in parallel balance check#1042
Merged
Conversation
✅ Deploy Preview for vortex-sandbox ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
- Add BalanceCheckError imports for proper error handling - Document 15-minute timeout rationale for bridge flows - Add isEvmNetwork type guard to validate EVM destinations - Fix type safety: balanceCheckPromise is Promise<Big> - Fix type safety: quote.outputCurrency as FiatToken - Use Error objects for rejected promises - Fix typo in comment (double space) - Handle Promise.any unhandled rejections with .catch() - Distinguish BalanceCheckError timeout vs read failure in error messages Co-authored-by: ebma <6690623+ebma@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add parallel balance check optimization to SquidRouter
Fix type safety and error handling in parallel balance check
Jan 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses code review feedback on the parallel balance check optimization for SquidRouter phase handler.
Type Safety
quote.outputCurrency:as any→as FiatTokenbalanceCheckPromise:Promise<any>→Promise<Big>isEvmNetwork()type guard to validate destination before EVM balance checksError Handling
Promise.any()inputs with.catch()to prevent unhandled rejections when the losing promise rejects after winner resolvesErrorobjects instead of plain stringsBalanceCheckErrortypes in failure messages:Timeout: Expected behavior when bridge is slowReadFailure: Unexpected infrastructure issueDocumentation
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.