Fix token lookup keying: preserve enum keys in dynamic EVM token merge#1061
Merged
Conversation
✅ Deploy Preview for vortex-sandbox ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
- Fix mergeWithStaticConfig to preserve static config enum keys (e.g., EvmToken.AXLUSDC) - Add alias entries under normalized symbols for flexible lookups - Remove special case for AXLUSDC in getOnChainTokenDetailsOrDefault - This fixes broken enum-based lookups like getOnChainTokenDetails(..., EvmToken.AXLUSDC) Co-authored-by: ebma <6690623+ebma@users.noreply.github.com>
Co-authored-by: ebma <6690623+ebma@users.noreply.github.com>
Co-authored-by: ebma <6690623+ebma@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update token selection list sorting logic
Fix token lookup keying: preserve enum keys in dynamic EVM token merge
Feb 6, 2026
ebma
approved these changes
Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
mergeWithStaticConfigfunction was keying merged tokens by normalized symbol ("USDC.AXL") instead of preserving static config enum keys (EvmToken.AXLUSDC), breaking enum-based lookups throughout the codebase.Changes
dynamicEvmTokens.ts: Iterate overObject.entries()instead ofObject.values()to preserve enum keys from static config"AXLUSDC") and normalized symbol (e.g.,"USDC.AXL") as aliases to the same objecthelpers.ts: Remove AXLUSDC special case ingetOnChainTokenDetailsOrDefault- no longer needed with proper keyingExample
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.