Updating Navbar#543
Closed
prayagd wants to merge 4 commits into
Closed
Conversation
✅ Deploy Preview for pendulum-pay ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Updated the links to the new navbar items
ebma
reviewed
Apr 3, 2025
| { title: t('components.navbar.community'), href: 'https://www.vortexfinance.co/#call-to-action' }, | ||
| { title: t('components.navbar.support'), href: 'https://pendulum.gitbook.io/vortex/support-and-contact' }, | ||
| { title: t('components.navbar.docs'), href: 'https://pendulum.gitbook.io/vortex' }, | ||
| { title: t('components.navbar.faq'), href: 'https://app.vortexfinance.co/#faq' }, |
Member
There was a problem hiding this comment.
What's the expected behavior for clicking on the FAQ link? Do you want it to scroll down on the same page or open a new page?
Member
Author
There was a problem hiding this comment.
scroll down to the same page to the faq section
Member
There was a problem hiding this comment.
This doesn't work in that case then. For one, you are always putting the production address so on deploy previews etc. it will always open a new page. If you feel like it, feel free to try troubleshooting it yourself with AI. Otherwise one of the @pendulum-chain/devs needs to add that before we can merge.
Member
|
Superseded by #605. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.