Fix progress bar percentage too low#565
Merged
Merged
Conversation
✅ Deploy Preview for pendulum-pay ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
gianfra-t
approved these changes
Apr 15, 2025
Contributor
gianfra-t
left a comment
gianfra-t
left a comment
There was a problem hiding this comment.
Lucky both ramp types have the same active count 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the progress bar only reaches ~50% when shown on the progress page before switching to the success page. This is because the total number of phases defined in the respective ramp-phase objects is larger than the relevant phases (as we need to exhaust the
RampPhasetype). This PR adds a custom constant to denote the relevant phases for the progress bar.This also runs prettier on all files.