Add support for already KYB'd businesses#570
Merged
Merged
Conversation
✅ Deploy Preview for pendulum-pay ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
ebma
reviewed
Apr 17, 2025
| // Response can also fail due to invalid KYC. Nevertheless, this should never be the case, as when we create the user we wait for the KYC | ||
| // to be valid, or retry. | ||
| if (response.status === 404) { | ||
| if (response.status === 404 && !isValidCnpj(taxId) && isValidCpf(taxId)) { |
Member
There was a problem hiding this comment.
It should be enough to only check for a valid CPF. The same input cannot be a valid CPF and CNPJ.
Suggested change
| if (response.status === 404 && !isValidCnpj(taxId) && isValidCpf(taxId)) { | |
| if (response.status === 404 && isValidCpf(taxId)) { |
| const PENDULUM_EPHEMERAL_STARTING_BALANCE_UNITS = '0.1'; // Amount to send to the new pendulum ephemeral account created | ||
| const MOONBEAM_EPHEMERAL_STARTING_BALANCE_UNITS = '3'; // Amount to send to the new moonbeam ephemeral account created | ||
| const BRLA_BASE_URL = 'https://api.brla.digital:5567/v1/business'; | ||
| const BRLA_BASE_URL = 'https://api.brla.digital:4567/v1/business'; |
Member
There was a problem hiding this comment.
Suggested change
| const BRLA_BASE_URL = 'https://api.brla.digital:4567/v1/business'; | |
| const BRLA_BASE_URL = 'https://api.brla.digital:5567/v1/business'; |
Refactored `RampFormValues` schema logic, moving it to a dedicated `ramp` hook and improving its modularity and reusability. Updated translations for CPF/CNPJ validation messages to support both identifiers consistently. Adjusted imports across components to reflect schema relocation.
Updated the ramp form schema and submission logic to incorporate `RampDirection`. Enhanced validation conditions for PIX ID based on ramp direction. Adjusted BRLA user fetching logic to use a dedicated service and improved error handling.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.