Fix WalletConnect connection issues#602
Merged
Merged
Conversation
✅ Deploy Preview for pendulum-pay ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses WalletConnect connection issues by updating walletconnect dependencies, adding error handling for address encoding failures, and cleaning up unused dependencies.
- Wrapped address encoding in a try-catch block to handle potential failures.
- Removed the obsolete getAddressForFormat function from the frontend helper file.
Reviewed Changes
Copilot reviewed 4 out of 6 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| shared/src/helpers/conversions.ts | Added try-catch around address encoding to catch and log errors. |
| frontend/src/helpers/addressFormatter.ts | Removed unused getAddressForFormat function to clean up dependencies. |
Files not reviewed (2)
- api/package.json: Language not supported
- frontend/package.json: Language not supported
Comments suppressed due to low confidence (1)
shared/src/helpers/conversions.ts:37
- [nitpick] Consider checking if the error is an instance of Error and logging error.message for more precise error details.
console.error(`Error encoding address ${address}: ${error}`);
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
apiproject