Skip to content

Fix WalletConnect connection issues#602

Merged
ebma merged 4 commits into
stagingfrom
fix-walletconnect-bug
Apr 28, 2025
Merged

Fix WalletConnect connection issues#602
ebma merged 4 commits into
stagingfrom
fix-walletconnect-bug

Conversation

@ebma
Copy link
Copy Markdown
Member

@ebma ebma commented Apr 28, 2025

  • Update walletconnect-related dependencies
  • Catch unhandled error when encoding an address fails
  • Remove unused dependency for api project

@ebma ebma requested review from a team and Copilot April 28, 2025 15:55
@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 28, 2025

Deploy Preview for pendulum-pay ready!

Name Link
🔨 Latest commit b4ccec0
🔍 Latest deploy log https://app.netlify.com/sites/pendulum-pay/deploys/680fa4f01a28bd00086ca81b
😎 Deploy Preview https://deploy-preview-602--pendulum-pay.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@ebma ebma requested a review from Copilot April 28, 2025 15:56
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses WalletConnect connection issues by updating walletconnect dependencies, adding error handling for address encoding failures, and cleaning up unused dependencies.

  • Wrapped address encoding in a try-catch block to handle potential failures.
  • Removed the obsolete getAddressForFormat function from the frontend helper file.

Reviewed Changes

Copilot reviewed 4 out of 6 changed files in this pull request and generated no comments.

File Description
shared/src/helpers/conversions.ts Added try-catch around address encoding to catch and log errors.
frontend/src/helpers/addressFormatter.ts Removed unused getAddressForFormat function to clean up dependencies.
Files not reviewed (2)
  • api/package.json: Language not supported
  • frontend/package.json: Language not supported
Comments suppressed due to low confidence (1)

shared/src/helpers/conversions.ts:37

  • [nitpick] Consider checking if the error is an instance of Error and logging error.message for more precise error details.
    console.error(`Error encoding address ${address}: ${error}`);

@ebma ebma merged commit eb785e0 into staging Apr 28, 2025
5 checks passed
@ebma ebma deleted the fix-walletconnect-bug branch April 28, 2025 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants