Skip to content

fix multiple progress page animation intervals causing % above 100#632

Merged
ebma merged 1 commit into
stagingfrom
fix/multiple-progress-intervals
May 13, 2025
Merged

fix multiple progress page animation intervals causing % above 100#632
ebma merged 1 commit into
stagingfrom
fix/multiple-progress-intervals

Conversation

@Sharqiewicz
Copy link
Copy Markdown
Member

@Sharqiewicz Sharqiewicz commented May 12, 2025

In order to avoid issues with percentage shown in the Progress page animation:

  • Ensuring that only one interval is active
  • Remove use of ref for following current percentage to avoid rendering errors

@netlify
Copy link
Copy Markdown

netlify Bot commented May 12, 2025

Deploy Preview for pendulum-pay ready!

Name Link
🔨 Latest commit df2e467
🔍 Latest deploy log https://app.netlify.com/sites/pendulum-pay/deploys/6821aa183ed495000819224a
😎 Deploy Preview https://deploy-preview-632--pendulum-pay.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ebma
Copy link
Copy Markdown
Member

ebma commented May 12, 2025

@Sharqiewicz can you please briefly describe in the description of your PR what the issue is? Otherwise I wouldn't really know what to pay attention to for the review.

@Sharqiewicz Sharqiewicz requested a review from Copilot May 12, 2025 15:16
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copy link
Copy Markdown
Member

@ebma ebma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't test it but it looks good ✅

@ebma ebma merged commit fef75c0 into staging May 13, 2025
5 checks passed
@ebma ebma deleted the fix/multiple-progress-intervals branch May 13, 2025 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants