Skip to content

Fix remaining limit check to allow valid amounts#650

Merged
ebma merged 1 commit into
stagingfrom
fix-remaining-limit-check-invalid
May 17, 2025
Merged

Fix remaining limit check to allow valid amounts#650
ebma merged 1 commit into
stagingfrom
fix-remaining-limit-check-invalid

Conversation

@ebma
Copy link
Copy Markdown
Member

@ebma ebma commented May 17, 2025

This pull request includes cleanup and a logic correction in the useRampAmountWithinAllowedLimits function within frontend/src/services/initialChecks.ts. The changes improve code clarity and fix a conditional check.

Code cleanup:

  • Removed unnecessary console.log statements that logged the kycLevel and remainingLimitNum values, reducing noise in the code. [1] [2]

Logic correction:

  • Updated the conditional check to correctly compare amountNum and remainingLimitNum, ensuring the function returns true when amountNum is less than or equal to remainingLimitNum instead of greater.

@ebma ebma merged commit a499c1e into staging May 17, 2025
1 check passed
@ebma ebma deleted the fix-remaining-limit-check-invalid branch May 17, 2025 13:45
@netlify
Copy link
Copy Markdown

netlify Bot commented May 17, 2025

Deploy Preview for pendulum-pay ready!

Name Link
🔨 Latest commit 0eb79af
🔍 Latest deploy log https://app.netlify.com/projects/pendulum-pay/deploys/682892d101d4a40008060ee7
😎 Deploy Preview https://deploy-preview-650--pendulum-pay.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant