UI Changes#704
Conversation
✅ Deploy Preview for pendulum-pay ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull Request Overview
This PR introduces various UI changes, translation updates, and functional improvements for onramp/offramp behavior. It includes additions to translation files, updates to state management in ramp-related stores and hooks, changes to UI appearance and behavior, and tweaks to tooltip and copy button behavior.
Reviewed Changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| frontend/src/translations/pt.json, en.json | Added new toast message "copyText" translations. |
| frontend/src/stores/rampDirectionStore.ts | Replaced the constant default with a dynamic direction based on the URL path. |
| frontend/src/stores/ramp/useRampFormStore.ts | Updated default fiat token and amount based on the detected language; new tokens added. |
| frontend/src/pages/ramp-form/index.tsx | Changed overflow behavior from visible to hidden. |
| frontend/src/hooks/useRampUrlParams.ts | Modified functions to derive token values with an additional rampDirection parameter. |
| frontend/src/hooks/ramp/useRampForm.ts | Refactored useEffect hooks to synchronize form state with store values. |
| frontend/src/helpers/path/index.tsx | Introduced a helper to parse ramp direction from the URL. |
| frontend/src/helpers/notifications.ts | Added a toast configuration for copy text notifications. |
| frontend/src/components/RampSummaryDialog/* | Removed unused variables and updated conditions for BRL onramp details. |
| frontend/src/components/RampFeeCollapse/index.tsx | Updated tooltip styling and adjusted container overflow. |
| frontend/src/components/LanguageSelector/index.tsx | Updated asset import for the US/English flag image. |
| frontend/src/components/CopyButton/index.tsx | Enhanced CopyButton to trigger a toast message on copy action. |
| frontend/App.css | Added CSS rule for new tooltip size. |
Comments suppressed due to low confidence (2)
frontend/src/hooks/useRampUrlParams.ts:48
- The logic forces the fiat token to FiatToken.BRL when the ramp direction is ONRAMP, regardless of the matched token. It would be beneficial to document this behavior explicitly or review if this is the intended API design.
if (rampDirection === RampDirection.ONRAMP && foundToken !== FiatToken.BRL) {
frontend/src/hooks/ramp/useRampForm.ts:105
- The refactoring of the fiatToken update from the removed useEffect to the new one may affect the synchronization between the form state and the store. Ensure that this change consistently maintains state integrity across component re-renders.
setFiatToken(constrainedToken);
ebma
left a comment
There was a problem hiding this comment.
Works overall, we just need to touch the default amount again, it's not properly applied for the EURC and ARS currency.
|
We also missed adding a CTA here on the summary dailog to click on the "I have made the payment" cc @pendulum-chain/devs |
Uh oh!
There was an error while loading. Please reload this page.