Skip to content

UI Changes#704

Merged
ebma merged 15 commits into
stagingfrom
698-update-the-default-state-of-the-app
Jun 6, 2025
Merged

UI Changes#704
ebma merged 15 commits into
stagingfrom
698-update-the-default-state-of-the-app

Conversation

@Sharqiewicz
Copy link
Copy Markdown
Member

@Sharqiewicz Sharqiewicz commented Jun 6, 2025

  • Hide PIX section when quote is expired.
  • Update default currencies and amounts
  • Change English flag
  • Add toast when PIX is copied
  • Fix Ramp Form animations and tooltips

@Sharqiewicz Sharqiewicz linked an issue Jun 6, 2025 that may be closed by this pull request
@netlify
Copy link
Copy Markdown

netlify Bot commented Jun 6, 2025

Deploy Preview for pendulum-pay ready!

Name Link
🔨 Latest commit bf09650
🔍 Latest deploy log https://app.netlify.com/projects/pendulum-pay/deploys/6842fd735779960008b2863b
😎 Deploy Preview https://deploy-preview-704--pendulum-pay.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@Sharqiewicz Sharqiewicz requested a review from Copilot June 6, 2025 14:38
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces various UI changes, translation updates, and functional improvements for onramp/offramp behavior. It includes additions to translation files, updates to state management in ramp-related stores and hooks, changes to UI appearance and behavior, and tweaks to tooltip and copy button behavior.

Reviewed Changes

Copilot reviewed 17 out of 17 changed files in this pull request and generated no comments.

Show a summary per file
File Description
frontend/src/translations/pt.json, en.json Added new toast message "copyText" translations.
frontend/src/stores/rampDirectionStore.ts Replaced the constant default with a dynamic direction based on the URL path.
frontend/src/stores/ramp/useRampFormStore.ts Updated default fiat token and amount based on the detected language; new tokens added.
frontend/src/pages/ramp-form/index.tsx Changed overflow behavior from visible to hidden.
frontend/src/hooks/useRampUrlParams.ts Modified functions to derive token values with an additional rampDirection parameter.
frontend/src/hooks/ramp/useRampForm.ts Refactored useEffect hooks to synchronize form state with store values.
frontend/src/helpers/path/index.tsx Introduced a helper to parse ramp direction from the URL.
frontend/src/helpers/notifications.ts Added a toast configuration for copy text notifications.
frontend/src/components/RampSummaryDialog/* Removed unused variables and updated conditions for BRL onramp details.
frontend/src/components/RampFeeCollapse/index.tsx Updated tooltip styling and adjusted container overflow.
frontend/src/components/LanguageSelector/index.tsx Updated asset import for the US/English flag image.
frontend/src/components/CopyButton/index.tsx Enhanced CopyButton to trigger a toast message on copy action.
frontend/App.css Added CSS rule for new tooltip size.
Comments suppressed due to low confidence (2)

frontend/src/hooks/useRampUrlParams.ts:48

  • The logic forces the fiat token to FiatToken.BRL when the ramp direction is ONRAMP, regardless of the matched token. It would be beneficial to document this behavior explicitly or review if this is the intended API design.
if (rampDirection === RampDirection.ONRAMP && foundToken !== FiatToken.BRL) {

frontend/src/hooks/ramp/useRampForm.ts:105

  • The refactoring of the fiatToken update from the removed useEffect to the new one may affect the synchronization between the form state and the store. Ensure that this change consistently maintains state integrity across component re-renders.
setFiatToken(constrainedToken);

@Sharqiewicz Sharqiewicz requested a review from a team June 6, 2025 14:42
Copy link
Copy Markdown
Member

@ebma ebma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works overall, we just need to touch the default amount again, it's not properly applied for the EURC and ARS currency.

@ebma ebma merged commit 2edc516 into staging Jun 6, 2025
5 checks passed
@ebma ebma deleted the 698-update-the-default-state-of-the-app branch June 6, 2025 15:22
@prayagd
Copy link
Copy Markdown
Member

prayagd commented Jun 10, 2025

We also missed adding a CTA here on the summary dailog to click on the "I have made the payment" cc @pendulum-chain/devs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update the default state of the app

4 participants