Fix /supported-cryptocurrencies endpoint#744
Merged
Sharqiewicz merged 11 commits intoJul 7, 2025
Merged
Conversation
…ken for every network in supported-currencies
✅ Deploy Preview for pendulum-pay ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances token support by updating backend mappings, extending EVM token configurations, and aligning frontend asset icons and displays.
- Adjusted cryptocurrency mapping logic and simplified the
SupportedCryptocurrencytype. - Added USDCE token configurations for both Arbitrum and Avalanche networks.
- Updated frontend to import ETH icon, switch EURC to SVG, and refresh the PopularTokens list (adding ETH, replacing EURC with EUR).
Reviewed Changes
Copilot reviewed 6 out of 18 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| apps/api/src/api/services/alchemypay/utils.ts | Updated CRYPTO_MAP to include eth and replaced "usdc.e" key. |
| packages/shared/src/endpoints/supported-cryptocurrencies.endpoints.ts | Removed unused import and aliased SupportedCryptocurrency to OnChainToken. |
| packages/shared/src/tokens/evm/config.ts | Added USDCE token entries under Arbitrum and Avalanche networks. |
| apps/frontend/src/hooks/useGetAssetIcon.tsx | Imported new ETH icon, upgraded EURC import to SVG, and added eth mapping. |
| apps/frontend/src/sections/PopularTokens/index.tsx | Added ETH to popular tokens and replaced EURC with EUR. |
Comments suppressed due to low confidence (3)
apps/frontend/src/sections/PopularTokens/index.tsx:16
- The token name 'BRLA' looks inconsistent with the asset icon key 'brl' and the standard currency code. Consider renaming it to 'BRL' for clarity.
{ assetIcon: "brl", name: "BRLA" },
packages/shared/src/tokens/evm/config.ts:118
- No unit test covers the new USDCE configuration for Arbitrum. Consider adding a test to verify
mapEvmTokenToDetailsreturns the expected details for USDCE on Arbitrum.
[EvmToken.USDCE]: {
packages/shared/src/tokens/evm/config.ts:202
- Similarly, add a unit test to confirm USDCE is correctly configured and returned for the Avalanche network.
[EvmToken.USDCE]: {
… table was not working for ETH)
ebma
reviewed
Jul 4, 2025
Member
ebma
left a comment
There was a problem hiding this comment.
Didn't test it but looks good to me overall 👍
The deploy preview fails though. Seems like one of the icons is mising or has a wrong name.
ebma
approved these changes
Jul 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces updates to cryptocurrency mappings, token configurations, and asset icons across multiple files to improve token handling and compatibility. Key changes include adjustments to token mappings, addition of new token configurations, and updates to asset icon imports and usage.
Cryptocurrency Mapping Updates:
apps/api/src/api/services/alchemypay/utils.ts: UpdatedCRYPTO_MAPto replace"usdc.e"with"usdce"for consistency and added a mapping foreth.Token Configuration Enhancements:
packages/shared/src/tokens/evm/config.ts: Added configurations forUSDCEtoken on both Arbitrum and Avalanche networks, including asset symbols, decimals, ERC-20 addresses, and network-specific icons. [1] [2]Asset Icon Updates:
apps/frontend/src/hooks/useGetAssetIcon.tsx: Imported new asset icons forETHand updated theEURCicon from.pngto.svg.apps/frontend/src/hooks/useGetAssetIcon.tsx: AddedETHto theICONSmapping for asset usage.Frontend Token Display Adjustments:
apps/frontend/src/sections/PopularTokens/index.tsx: Updated thetokensarray to includeETHand replacedEURCwithEURfor display purposes.Type Definition Simplifications:
packages/shared/src/endpoints/supported-cryptocurrencies.endpoints.ts: Simplified theSupportedCryptocurrencytype by directly usingOnChainToken.