[Snyk] Security upgrade cross-spawn from 7.0.3 to 7.0.5 - #1775
Closed
AgnellusX1 wants to merge 1 commit into
Closed
Conversation
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-CROSSSPAWN-8303230
pankaj443
added a commit
that referenced
this pull request
Jun 2, 2026
Replace the header-only/truncated base64 mp4 (a 32-byte ftyp box with no moov/mdat) with a complete, spec-valid minimal mp4 (ftyp+free+mdat+moov). The original stub engaged the media pipeline in a way the upgraded Firefox 146 renderer (percy-renderer #1775, FF 139.0.4 -> 146.0.1) failed to render, causing the Comprehensive snapshot to time out on Firefox. The discovery/serialization path is identical across CLI versions (verified: old v126 and new v143 CLI both timed out), so the fixture must carry media the renderer can actually parse. Using a valid source keeps the data-URI video serialization path under test (serialize-video / serializeBase64) while no longer hanging the renderer. Locally the video now reports networkState=IDLE with no decode error in both Chromium and Firefox (the stub reported NO_SOURCE). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
pankaj443
added a commit
that referenced
this pull request
Jun 5, 2026
* test: re-add comprehensive.html regression fixture Restore the comprehensive regression test page that was removed in PR #2239. The fixture exercises fonts, pseudo-class CSS rules, and other web features used by the regression suite. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * test: comment out video element to verify issue Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * test: drop unplayable mp4 source from video poster fixture The <video> carried a header-only base64 mp4 <source> (a 32-byte ftyp box with no moov/mdat). It's unplayable and serves no purpose for this fixture, whose goal is exercising video *poster* handling — serialize- video.js skips elements that already have a poster attribute, so the source was never part of any capture path. The stub engages the browser media pipeline, which the upgraded (v143- era) Firefox renderer handles differently than v126, causing the Comprehensive snapshot to fail rendering on Firefox. Removing the source leaves networkState=EMPTY (no load attempt) in both Chromium and Firefox while keeping the poster — the actual thing under test. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * test: use a valid mp4 source in video poster fixture Replace the header-only/truncated base64 mp4 (a 32-byte ftyp box with no moov/mdat) with a complete, spec-valid minimal mp4 (ftyp+free+mdat+moov). The original stub engaged the media pipeline in a way the upgraded Firefox 146 renderer (percy-renderer #1775, FF 139.0.4 -> 146.0.1) failed to render, causing the Comprehensive snapshot to time out on Firefox. The discovery/serialization path is identical across CLI versions (verified: old v126 and new v143 CLI both timed out), so the fixture must carry media the renderer can actually parse. Using a valid source keeps the data-URI video serialization path under test (serialize-video / serializeBase64) while no longer hanging the renderer. Locally the video now reports networkState=IDLE with no decode error in both Chromium and Firefox (the stub reported NO_SOURCE). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Snyk has created this PR to fix 1 vulnerabilities in the yarn dependencies of this project.
Snyk changed the following file(s):
packages/cli-exec/package.jsonNote for zero-installs users
If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the
.yarn/cache/directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to runyarnto update the contents of the./yarn/cachedirectory.If you are not using zero-install you can ignore this as your flow should likely be unchanged.
Vulnerabilities that will be fixed with an upgrade:
SNYK-JS-CROSSSPAWN-8303230
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Regular Expression Denial of Service (ReDoS)