🐛 Fix CSSOM check#87
Merged
Merged
Conversation
Sometimes innerText can be undefined which causes this function to error when it should report true.
Robdel12
approved these changes
Nov 19, 2020
Robdel12
left a comment
Robdel12
left a comment
Contributor
There was a problem hiding this comment.
🏁
Just curious -- what stage is that operator?
Contributor
|
Oh nice, most browsers shipped: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Optional_chaining#Browser_compatibility assuming stage 3+ then Edit: stage 4, dope https://github.com/tc39/proposal-optional-chaining |
Contributor
Author
|
Stage 4, has been shipped to the major browsers already and node 14. But we transpile with babel anyway. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this?
Sometimes
innerTextcan be undefined which causes this function to error when it should report true. This check is present in the old serialization script in agent, but it couldn't be confirmed if it was needed since I'm not quite sure how to replicate that behavior to test it.