Skip to content

Add missing string placeholder in string format#8

Merged
anaulin merged 1 commit into
masterfrom
fix-missing-s
Jan 17, 2019
Merged

Add missing string placeholder in string format#8
anaulin merged 1 commit into
masterfrom
fix-missing-s

Conversation

@anaulin

@anaulin anaulin commented Jan 17, 2019

Copy link
Copy Markdown
Contributor

We don't have a test case that would catch this situation, since this is the "unexpected WebDriver type" path, and I'm not convinced it's worth adding right now.

Fixes #7

@anaulin
anaulin requested a review from djones January 17, 2019 19:54

@djones djones left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍍 LGTM

@anaulin
anaulin merged commit e176c5f into master Jan 17, 2019
@anaulin
anaulin deleted the fix-missing-s branch January 17, 2019 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants