Skip to content

Fix warnings in Xcode 16.2#879

Merged
ileitch merged 2 commits into
peripheryapp:masterfrom
jszumski:fix-xcode16.2-warnings
Feb 14, 2025
Merged

Fix warnings in Xcode 16.2#879
ileitch merged 2 commits into
peripheryapp:masterfrom
jszumski:fix-xcode16.2-warnings

Conversation

@jszumski
Copy link
Copy Markdown
Contributor

@jszumski jszumski commented Feb 7, 2025

Fixes these warnings by fully qualifying the cross-module conformances:

Sources/Configuration/Configuration.swift:338:1 Extension declares a conformance of imported type 'FilePath' to imported protocols 'ScalarRepresentable', 'NodeRepresentable'; this will not behave correctly if the owners of 'SystemPackage' introduce this conformance in the future

Sources/Extensions/FilePath+Extension.swift:71:1 Extension declares a conformance of imported type 'FilePath' to imported protocol 'Comparable'; this will not behave correctly if the owners of 'SystemPackage' introduce this conformance in the future

Fixes this warning by making the variable immutable:

Sources/Shared/SetupGuide.swift:55:13 Variable 'helpMsg' was never mutated; consider changing to 'let' constant

@ileitch ileitch merged commit 7ffb37b into peripheryapp:master Feb 14, 2025
@jszumski jszumski deleted the fix-xcode16.2-warnings branch February 14, 2025 15:34
rofle100lvl pushed a commit to rofle100lvl/periphery that referenced this pull request Mar 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants