Fixes Convert-FailureLines for Core vs. Desktop PS

[fourpastmidnight]

For the desktop version of Powershell, when getting the exception
message, there would be 3 lines: the exeception name and message, any
parameter name, and then the inner exception type (and first line
message):

<Exception Name>: <first message line>
Parameter: <param name>
<Inner Exception Name>: <first inner exn line>

But, in PowerShell Core (7.0?), the output looked like this:

<Exception name>: <first message line> (Parameter '<param name>')
<Inner Exception name>: <first inner exn line>

This commit detects whether the first message line matches a regex that
matches the parenthesized parameter name in the first message line, and
if so, splits the line into two. This "normalizes" the message lines
between PowerShell Desktop and PowerShell Core.

[fourpastmidnight]

@nohwnd Is it possible to get this merged? It's blocking successful test passes for PR #1276, which I would love to finally get merged! 😄

[nohwnd]

Done, sorry for the holdup, I mostly ignore Pester notifications during week, because I work on github and they would distract me :)

[fourpastmidnight]

Oh! Sure. I’ll keep that in mind for the future. And, thanks!!

…

Sent from my Windows 10 phone From: Jakub Jareš Sent: Saturday, April 4, 2020 1:58 To: pester/Pester Cc: Craig E. Shea; Author Subject: Re: [pester/Pester] Fixes Convert-FailureLines for Core vs. DesktopPS (#1475) Done, sorry for the holdup, I mostly ignore Pester notifications during week, because I work on github and they would distract me :) — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.