fix: replace standalone dependency-audit.yml with org standard thin caller stub#217
fix: replace standalone dependency-audit.yml with org standard thin caller stub#217don-petry wants to merge 4 commits into
Conversation
|
Warning Review limit reached
More reviews will be available in 49 minutes and 54 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits. 🚦 How do rate limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe dependency-audit workflow is simplified to delegate all ecosystem detection and vulnerability scanning logic to a centralized org-level reusable workflow. The in-repo job graph (npm, pnpm, govulncheck, cargo-audit, pip-audit) is removed and replaced with a single job that calls ChangesWorkflow Delegation
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
CI is green on all primary checks. @petry-projects/org-leads — this PR is ready for review and merge. It resolves the long-standing compliance finding by replacing the out-of-date standalone |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/dependency-audit.yml:
- Around line 32-33: Update the reusable workflow reference for the
dependency-audit job so it uses the exact commit SHA instead of the floating
tag; locate the "dependency-audit" job and replace the uses:
petry-projects/.github/.github/workflows/dependency-audit-reusable.yml@v1
reference with the corresponding commit SHA (the one resolved via the GitHub
API, e.g., 0cb4bba11d7563bf197ad805f12fb8639e4879e4) — make this change first in
the upstream template (petry-projects/.github) and then sync the updated file
into this repository so the workflow here points to the pinned SHA.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: 623a0528-780e-499d-b8d0-38650618d3cb
📒 Files selected for processing (1)
.github/workflows/dependency-audit.yml
There was a problem hiding this comment.
Pull request overview
Migrates the repository’s dependency-audit.yml from a standalone, inline implementation to the org-standard thin caller stub that delegates to the centralized reusable workflow, removing the previously unpinned third-party Rust toolchain action from this repo-level workflow.
Changes:
- Replaced the standalone multi-ecosystem audit workflow with the org-standard thin caller stub.
- Delegated execution to
petry-projects/.github/.github/workflows/dependency-audit-reusable.yml@v1.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Auto-rebase failed — merge conflict — this branch has conflicts with Please resolve the conflicts and push: |
e197456 to
f2da3f4
Compare
Superseded by automated re-review at
|
|
Auto-rebase failed — merge conflict — this branch has conflicts with Claude will attempt to resolve this automatically. If it cannot, a follow-up comment will explain what needs manual attention. To resolve manually instead: |
|
Auto-rebase failed — merge conflict — this branch has conflicts with Claude will attempt to resolve this automatically. If it cannot, a follow-up comment will explain what needs manual attention. To resolve manually instead: |
1ecc69b to
7dd04ca
Compare
Auto-rebase complete ✓The PR branch has been successfully rebased onto `main`. Conflict resolutionFile: `.github/workflows/dependency-audit.yml`
Resolution: Kept the PR branch version (thin caller stub). The only difference between main and the PR's base was a SHA pin for `dtolnay/rust-toolchain@stable` → `@29eef336...`. Since the PR replaces the entire standalone workflow with the org-standard thin stub (which delegates all logic — including Rust toolchain setup — to the centrally-maintained reusable), the standalone workflow's pin update is superseded by the PR's change. This falls under the action-pin conflict resolution rule: the PR's approach is the correct one per org standards. New HEAD``` Parent: `761dd4a` (current `main` tip — fix: disable check-suite auto-trigger for Claude and CodeRabbit on .github (#275))
|
Dev-Lead Fix CI — failedPR: #217 | SHA: |
Dev-Lead Fix CI — failedPR: #217 | SHA: |
Dev-Lead Fix CI — exhaustedThis PR has had 2 consecutive engine failures (timeouts or errors). Automated CI fixing has been paused to avoid consuming further tokens. Reason for last failure: Engine invocation failed (exit 1) To re-enable, delete this comment or push a new commit with a substantially different change. |
|
|
Auto-rebase failed — merge conflict — this branch has conflicts with Claude will attempt to resolve this automatically. If it cannot, a follow-up comment will explain what needs manual attention. To resolve manually instead: |
|
Auto-rebase failed — merge conflict — this branch has conflicts with Claude will attempt to resolve this automatically. If it cannot, a follow-up comment will explain what needs manual attention. To resolve manually instead: |
|
Auto-rebase failed — merge conflict — this branch has conflicts with Claude will attempt to resolve this automatically. If it cannot, a follow-up comment will explain what needs manual attention. To resolve manually instead: |
|
Auto-rebase failed — merge conflict — this branch has conflicts with Claude will attempt to resolve this automatically. If it cannot, a follow-up comment will explain what needs manual attention. To resolve manually instead: |
|
@donpetry-bot I'm on it — starting a fresh review now. Results will appear in a few minutes. |
3 similar comments
|
@donpetry-bot I'm on it — starting a fresh review now. Results will appear in a few minutes. |
|
@donpetry-bot I'm on it — starting a fresh review now. Results will appear in a few minutes. |
|
@donpetry-bot I'm on it — starting a fresh review now. Results will appear in a few minutes. |
Dev-Lead — review-changes (no-changes)No changes were needed for this PR. |
donpetry-bot
left a comment
There was a problem hiding this comment.
Automated review — APPROVED ✓
Risk: LOW
Reviewed commit: d7fb049b1984874ce2f44f982f7c33932c048215
Review mode: triage-approved (single reviewer)
Summary
Replaces the 200-line standalone dependency-audit.yml with the org-standard thin caller stub that delegates to the SHA-pinned reusable workflow. Net -185 lines across 2 files. Removes the third-party rust-toolchain action flagged by compliance and aligns the standards/ copy verbatim.
Linked issue analysis
Closes #106 (compliance: unpinned-actions-dependency-audit.yml — dtolnay/rust-toolchain@stable). Fully addressed: the offending action is removed entirely, not re-pinned — the workflow now delegates all ecosystem detection/audit logic to the reusable. The new uses: ref is pinned to SHA d3d768d (verified to resolve in petry-projects/.github), satisfying the action-pinning standard.
Findings
No blocking findings.
- AGENTS.md SHA-pinning rule honored: reusable pinned to
d3d768dabb7f28cc63283cdfe48630da53700e50 # v1(verified via API). - Both
.github/workflows/dependency-audit.ymlandstandards/workflows/dependency-audit.ymlare now identical, matching the source-of-truth convention. - Required status check
dependency-audit / Detect ecosystemsis present and green, so branch protection remains satisfied. - Permissions unchanged (
contents: read); no new secrets, no GitHub Actions security smells. - Nit (non-blocking): doc anchor corrected from
#5...dependency-auditymto#7...dependency-audit.yml. mergeStateStatusis BEHIND (branch behind main) — not a review blocker; rebase/merge gate handles it.
CI status
All checks pass — CodeQL, SonarCloud, ShellCheck, Lint, agent-shield/AgentShield, gitleaks secret scan, Agent Security Scan, CodeRabbit, and dependency-audit all SUCCESS. Ecosystem-specific audit jobs (npm/pnpm/cargo/go/pip) SKIPPED as expected (no matching manifests). No FAILURE or CANCELLED checks. Owner and CodeRabbit have APPROVED.
Reviewed automatically by the PR-review agent (single-reviewer mode: fable 5). Reply if you need a human review.
Dev-Lead — waiting on PR blockers (intent: review-changes)PR: #217 |
|
Note @don-petry I reviewed this PR and no code changes were needed, but it still has blocking checks or reviews (failing or cancelled checks, or changes-requested reviews), so I cannot mark it done yet. I'll re-check automatically. |
Dev-Lead — review-changes (no-changes)No changes were needed for this PR. |
|
Auto-rebase failed — merge conflict — this branch has conflicts with dev-lead will attempt to resolve this automatically. If it cannot, a follow-up comment will explain what needs manual attention. To resolve manually instead: |
|
Auto-rebase failed — merge conflict — this branch has conflicts with dev-lead will attempt to resolve this automatically. If it cannot, a follow-up comment will explain what needs manual attention. To resolve manually instead: |
|
Auto-rebase failed — merge conflict — this branch has conflicts with dev-lead will attempt to resolve this automatically. If it cannot, a follow-up comment will explain what needs manual attention. To resolve manually instead: |
|
Auto-rebase failed — merge conflict — this branch has conflicts with dev-lead will attempt to resolve this automatically. If it cannot, a follow-up comment will explain what needs manual attention. To resolve manually instead: |
|
Auto-rebase failed — merge conflict — this branch has conflicts with dev-lead will attempt to resolve this automatically. If it cannot, a follow-up comment will explain what needs manual attention. To resolve manually instead: |
|
Auto-rebase failed — merge conflict — this branch has conflicts with dev-lead will attempt to resolve this automatically. If it cannot, a follow-up comment will explain what needs manual attention. To resolve manually instead: |
|
Auto-rebase failed — merge conflict — this branch has conflicts with dev-lead will attempt to resolve this automatically. If it cannot, a follow-up comment will explain what needs manual attention. To resolve manually instead: |
|
Auto-rebase failed — merge conflict — this branch has conflicts with dev-lead will attempt to resolve this automatically. If it cannot, a follow-up comment will explain what needs manual attention. To resolve manually instead: |
…aller stub Replaces the standalone workflow (which contained the unpinned dtolnay/rust-toolchain@stable action) with the org-standard thin caller stub that delegates to the centrally-maintained reusable workflow. The reusable workflow uses rustup directly, removing the third-party action entirely. Closes #106 Rebased onto main by claude[bot] (auto-rebase). Co-authored-by: Don Petry <don-petry@users.noreply.github.com>
Dev-Lead — rebase (applied)Rebase completed and pushed. |
Dev-Lead — fix-bot-comment (no-changes)Agent reasoning |
donpetry-bot
left a comment
There was a problem hiding this comment.
Automated review — APPROVED ✓
Risk: LOW
Reviewed commit: f0e9953d9d053fd2aafbd4f24afe9a15b9d62cd6
Review mode: triage-approved (single reviewer)
Summary
Replaces the standalone dependency-audit.yml (which carried the unpinned dtolnay/rust-toolchain@stable action) with the org-standard thin caller stub delegating to dependency-audit-reusable.yml, and pins that reusable from the @dependency-audit/stable branch ref to commit SHA d3d768da (# v1). Net -185 lines. A security-positive compliance fix; the two workflow copies are byte-identical and the standard's doc anchor typo is corrected.
Linked issue analysis
Closes #106 (compliance: unpinned-actions-dependency-audit.yml, severity error). The finding flagged exactly one unpinned action — dtolnay/rust-toolchain@stable. This PR deletes that action along with the whole standalone job graph, so the finding is substantively resolved.
Findings
- Verified the pinned ref
d3d768dabb7f28cc63283cdfe48630da53700e50is a real commit inpetry-projects/.githuband that.github/workflows/dependency-audit-reusable.ymlexists at that ref — pin is valid, not guessed (per AGENTS.md). - Confirmed
.github/workflows/dependency-audit.ymlandstandards/workflows/dependency-audit.ymlare byte-identical at the head SHA (verbatim adoption, as required). - No remaining third-party actions or unpinned refs in the changed files.
- No unresolved review threads; prior CodeRabbit change-request was dismissed and SonarCloud quality gate now passes.
No blocking issues.
CI status
All required checks green: ShellCheck, Lint, CodeQL, Analyze (actions), Secret scan (gitleaks), Agent Security Scan, agent-shield, SonarCloud (quality gate passed), dependency-audit / Detect ecosystems. The two CANCELLED dev-lead checks are from intentional [skip ci-relay] commits; per-ecosystem audit jobs SKIPPED as expected (no matching lockfiles in this repo). mergeable=MERGEABLE.
Reviewed automatically by the PR-review agent (single-reviewer mode: fable 5). Reply if you need a human review.
|
Dev-Lead — review-changes (no-changes)No changes were needed for this PR. |





Summary
dependency-audit.ymlworkflow (which contained the unpinneddtolnay/rust-toolchain@stableaction) with the org-standard thin caller stubdependency-audit-reusable.yml, which usesrustupdirectly — eliminating the third-party action and its pinning violationstandards/workflows/dependency-audit.ymlper the AGENTS.md standardRoot cause
The standalone workflow was out of sync with the org standard. The reusable workflow was already updated to use
rustupdirectly (no third-party action), but the caller was never migrated from the old standalone form to the thin caller stub.Test plan
dependency-audit.ymlfor unpinned actionsCloses #106
Generated with Claude Code
Summary by CodeRabbit