chore: add dev-lead.yml to DEPLOYABLE_WORKFLOWS#324
Conversation
Makes dev-lead.yml an auto-deployed org-standard stub alongside pr-review-mention.yml. All repos were manually synced to current version as part of this rollout. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe ChangesWorkflow allowlist update
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull request overview
This PR adds the Dev-Lead workflow stub to the standard workflow deployment script so it can be rolled out across organization repositories.
Changes:
- Adds
dev-lead.ymltoDEPLOYABLE_WORKFLOWS.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| # feature-ideation.yml (requires repo-specific project_context input). | ||
| DEPLOYABLE_WORKFLOWS=( | ||
| pr-review-mention.yml | ||
| dev-lead.yml |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f0677eba15
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| # feature-ideation.yml (requires repo-specific project_context input). | ||
| DEPLOYABLE_WORKFLOWS=( | ||
| pr-review-mention.yml | ||
| dev-lead.yml |
There was a problem hiding this comment.
Adding dev-lead.yml to the all-repo deploy list will push standards/workflows/dev-lead.yml verbatim, but that template currently calls petry-projects/.github-private/.github/workflows/dev-lead-reusable.yml@main while scripts/compliance-audit.sh checks downstream repos for petry-projects/.github/.github/workflows/dev-lead-reusable.yml@v1 (see check_centralized_workflow_stubs). In any repo touched by this deployment, the deploy script’s own dry-run can report “already compliant” because it compares against the template, but the org compliance audit will still flag the workflow as non-canonical. Please align the dev-lead template/audit expectation before enabling it for bulk deployment.
Useful? React with 👍 / 👎.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds the dev-lead.yml workflow to the DEPLOYABLE_WORKFLOWS list in the deployment script. A review comment highlights a conflict between this automated synchronization and the workflow's internal documentation, which suggests it can be modified locally. The reviewer recommends either excluding the workflow from the deployment script or updating the template to clarify that it is enforced verbatim to prevent local changes from being overwritten.
| # feature-ideation.yml (requires repo-specific project_context input). | ||
| DEPLOYABLE_WORKFLOWS=( | ||
| pr-review-mention.yml | ||
| dev-lead.yml |
There was a problem hiding this comment.
Adding dev-lead.yml to the DEPLOYABLE_WORKFLOWS list enables verbatim synchronization across all repositories. However, the dev-lead.yml template itself (lines 12-13) contains a comment stating it 'may be freely modified on PR branches to adjust triggers'. There is a conflict here: if a repository owner customizes the triggers, those changes will be silently overwritten by this script whenever the central template's uses: version is updated or if the script is run with --force. If the workflow is intended to be customizable at the repository level, it should likely be excluded from this list (similar to feature-ideation.yml). If it should be enforced verbatim, the misleading comment in standards/workflows/dev-lead.yml should be removed to avoid developer confusion.
Review — fix requested (cycle 1/3)The automated review identified the following issues. Please address each one: Findings to fixAutomated review — NEEDS HUMAN REVIEWRisk: MEDIUM SummaryThe diff itself is trivial — one line adding Flagging for human confirmation since the triage tier classified this as trivial low-risk. Linked issue analysisNo linked issue. Related context: PR #301 (promote dev-lead.yml in ci-standards) and PR #302 (per-workflow version tags in stub checker). FindingsTemplate / compliance-audit mismatch (carry-forward from Copilot + Codex + Gemini threads):
This mismatch already exists on Suggested resolutions (pick one before bulk rollout):
Gemini's secondary concern about the "may be freely modified on PR branches" comment at CI statusAll required checks green (Lint, ShellCheck, CodeQL, SonarCloud, Secret scan, AgentShield, Agent Security Scan). CodeRabbit auto-approved; Copilot/Codex/Gemini are Reviewed automatically by the PR-review agent (single-reviewer mode: opus 4.7). Reply if you need a human review. Additional tasks
The review cascade will automatically re-review after new commits are pushed. |
Makes dev-lead.yml an auto-deployed org-standard stub alongside pr-review-mention.yml. All repos were manually synced to current version as part of this rollout. Co-authored-by: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Makes dev-lead.yml an auto-deployed org-standard stub alongside pr-review-mention.yml. All repos were manually synced to current version as part of this rollout. Co-authored-by: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Makes dev-lead.yml an auto-deployed org-standard stub alongside pr-review-mention.yml. All repos were manually synced to current version as part of this rollout. Co-authored-by: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Makes dev-lead.yml an auto-deployed org-standard stub alongside pr-review-mention.yml. All repos were manually synced to current version as part of this rollout. Co-authored-by: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Makes dev-lead.yml an auto-deployed org-standard stub alongside pr-review-mention.yml. All repos were manually synced to current version as part of this rollout. Co-authored-by: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Summary
dev-lead.ymlto theDEPLOYABLE_WORKFLOWSlist indeploy-standard-workflows.shso the dev-lead caller stub is auto-deployed to all org repos going forward.Test plan
bash scripts/deploy-standard-workflows.sh --dry-runreports all repos compliant for bothdev-lead.ymlandpr-review-mention.yml🤖 Generated with Claude Code
Summary by CodeRabbit