fix(pr-quality): require last push approval — align codified ruleset with org policy (#575) by don-petry · Pull Request #582 · petry-projects/.github

don-petry · 2026-07-02T22:34:44Z

Summary

Sets require_last_push_approval: true in the codified standards/rulesets/pr-quality.json. Answers the review question on petry-projects/.github-private#1013: there is no good reason for it to be false — it was baked in at authoring time (#972), and the org's actual policy is true.

Evidence

Live require_last_push_approval across the fleet is split (drift):

true	false
`.github`, `.github-private`, `TalkTerm`, `google-app-scripts`	`ContentTwin`, `markets`, `broodly`

The meta-repos and newer repos already enforce true — that's the intended policy.
#895 verified auto-rebase's update-branch is exempt from require_last_push_approval (and dismiss-stale), so enabling it does not fight the auto-rebase flow — the historical worry that would justify false.

Blast radius

On the next apply-rulesets.sh run this tightens the three drifted repos still at false (ContentTwin, markets, broodly) and is a no-op on the four already at true. The applier is operator-invoked, so this takes effect deliberately, not automatically.

Notes

Stacked on chore(rulesets): relocate code-quality + pr-quality to standards/rulesets/ (#575) #577 (base = chore/relocate-rulesets-575) so the diff is the single line; retargets to main when chore(rulesets): relocate code-quality + pr-quality to standards/rulesets/ (#575) #577 merges.
Resolves the pre-existing pr-quality file-vs-live drift flagged in chore(rulesets): repoint apply-rulesets + bootstrap to .github fleet source (#575) .github-private#1013.

Part of #575.

🤖 Generated with Claude Code

…with org policy (#575) The codified pr-quality had require_last_push_approval=false, baked in when the file was authored (#972). That contradicts the org's actual policy: the meta-repos (.github, .github-private) and newer repos (TalkTerm, google-app-scripts) already enforce require_last_push_approval=true live, and #895 verified auto-rebase's update-branch is EXEMPT from last-push-approval (so enabling it does not fight the auto-rebase flow). Set the codified source of truth to true. Blast radius on next apply-rulesets run: tightens the three drifted repos still at false (ContentTwin, markets, broodly); no-op on the four already at true. Stacked on #577 (the relocation). Resolves the pr-quality file-vs-live drift flagged in petry-projects/.github-private#1013. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

chatgpt-codex-connector · 2026-07-02T22:34:47Z

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

coderabbitai · 2026-07-02T22:34:54Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: c77b95df-62fb-4280-a69b-988d07d5502f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch fix/pr-quality-require-last-push-approval

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

gemini-code-assist

Code Review

This pull request updates the pull request quality ruleset configuration in standards/rulesets/pr-quality.json to enable the require_last_push_approval setting. There are no review comments, and I have no additional feedback to provide.

don-petry · 2026-07-02T22:35:40Z

Dev-Lead — fix-bot-comment (no-changes)

Agent reasoning

Issues addressed: 0
- No actionable code review issues found
Files changed: None (PR is approved as-is)
Skipped (informational): 1 (Codex limit message is system error, not a code finding)
```
The PR is ready to merge pending CI completion.

Copilot

Pull request overview

Aligns the codified pr-quality ruleset definition with the organization’s intended policy by enabling “require last push approval” in standards/rulesets/pr-quality.json.

Changes:

Set require_last_push_approval to true in the pr-quality ruleset JSON.

        "required_review_thread_resolution": true,
        "dismiss_stale_reviews_on_push": true,
-        "require_last_push_approval": false,
+        "require_last_push_approval": true,


…sets/ (#575) (#577) * chore(rulesets): relocate code-quality + pr-quality JSON to standards/rulesets/ (#575) Move the org-wide compliance ruleset source of truth into its canonical home in petry-projects/.github. `.github` owns org-wide standards and compliance policy; `.github-private` is scoped to agents/skills and their assets (repo boundary codified in #576). - Add standards/rulesets/{code-quality,pr-quality}.json — byte-identical to the current .github-private/.github/rulesets/ copies (the 4-check code-quality set; NO coverage/secret-scan additions, which are sequenced separately to avoid bricking fleet repos that don't yet produce those checks). - Add standards/rulesets/README.md documenting source-of-truth, the scope boundary (release-channel-tags stays in .github-private), and the safe-sequencing rule for required-check additions. - github-settings.md: add a "Source of truth" pointer to standards/rulesets/. - AGENTS.md: add a Rulesets row to the Organization Standards index. The tooling repoint (apply-rulesets.sh + bootstrap-new-repo.sh) and removal of the JSONs from .github-private land in a follow-up PR against .github-private, which must merge after this one. Part of #575. Follows #576. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * fix(pr-quality): require last push approval — align codified ruleset with org policy (#575) (#582) The codified pr-quality had require_last_push_approval=false, baked in when the file was authored (#972). That contradicts the org's actual policy: the meta-repos (.github, .github-private) and newer repos (TalkTerm, google-app-scripts) already enforce require_last_push_approval=true live, and #895 verified auto-rebase's update-branch is EXEMPT from last-push-approval (so enabling it does not fight the auto-rebase flow). Set the codified source of truth to true. Blast radius on next apply-rulesets run: tightens the three drifted repos still at false (ContentTwin, markets, broodly); no-op on the four already at true. Stacked on #577 (the relocation). Resolves the pr-quality file-vs-live drift flagged in petry-projects/.github-private#1013. Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * chore: dev-lead update (review-changes) [skip ci-relay] --------- Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Co-authored-by: donpetry-bot <281750570+donpetry-bot@users.noreply.github.com> Co-authored-by: Don Petry Bot <donpetry+bot@gmail.com>

Copilot AI review requested due to automatic review settings July 2, 2026 22:34

don-petry requested a review from a team as a code owner July 2, 2026 22:34

Copilot started reviewing on behalf of don-petry July 2, 2026 22:35 View session

gemini-code-assist Bot reviewed Jul 2, 2026

View reviewed changes

don-petry merged commit 0dc0f02 into chore/relocate-rulesets-575 Jul 2, 2026
8 of 10 checks passed

don-petry deleted the fix/pr-quality-require-last-push-approval branch July 2, 2026 22:35

Copilot AI reviewed Jul 2, 2026

View reviewed changes

Comment thread standards/rulesets/pr-quality.json

"required_review_thread_resolution": true,

"dismiss_stale_reviews_on_push": true,

"require_last_push_approval": false,

"require_last_push_approval": true,

don-petry mentioned this pull request Jul 3, 2026

Relocate org-wide compliance rulesets (code-quality, pr-quality) from .github-private to .github/standards/rulesets/ #575

Closed

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(pr-quality): require last push approval — align codified ruleset with org policy (#575)#582

fix(pr-quality): require last push approval — align codified ruleset with org policy (#575)#582
don-petry merged 1 commit into
chore/relocate-rulesets-575from
fix/pr-quality-require-last-push-approval

don-petry commented Jul 2, 2026

Uh oh!

chatgpt-codex-connector Bot commented Jul 2, 2026

Uh oh!

coderabbitai Bot commented Jul 2, 2026

Review skipped

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

don-petry commented Jul 2, 2026

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

don-petry commented Jul 2, 2026

Summary

Evidence

Blast radius

Notes

Uh oh!

chatgpt-codex-connector Bot commented Jul 2, 2026

Uh oh!

coderabbitai Bot commented Jul 2, 2026

Review skipped

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

don-petry commented Jul 2, 2026

Dev-Lead — fix-bot-comment (no-changes)

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants