docs: define release-manager App required permissions (incl. Workflows:write)#812
Conversation
…s:write) The canary-rollout header listed the App's perms but omitted Workflows:write, which #807 established is REQUIRED to move channel tags on workflow-heavy repos like .github (else 403 'Resource not accessible by integration'). Spell out the full required-permission set + the grant-AND-request rule (create-github-app-token drops any permission the mint step doesn't list). Also fix the stale ADR line that still named GH_PAT_WORKFLOWS as the mover. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Warning Review limit reached
Next review available in: 39 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Dev-Lead — review-changes (no-changes)No changes were needed for this PR. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the Architecture Decision Record (ADR) for agent canary rings to specify that the promotion workflow authenticates using the petry-projects-release-manager GitHub App, listing its required repository permissions. The reviewer suggested standardizing these permission names to lowercase to align with standard GitHub Actions syntax and facilitate copy-pasting.
There was a problem hiding this comment.
Pull request overview
Updates internal documentation to explicitly capture the full GitHub App permission set required by petry-projects-release-manager for canary promotions—especially Workflows:write, which is necessary for moving channel tags on .github when workflow files are involved—reinforcing the “grant AND request” rule established in #807.
Changes:
- Expand the
canary-rollout.ymlheader comment to enumerate required App repo permissions, with rationale forWorkflows:write. - Update the agent canary rings ADR to record the App identity, bypass-actor requirement, and the full permission set (and why
Workflows:writematters).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
docs/initiatives/agent-canary-rings-adr.md |
Documents the release-manager App’s required permissions and ties the Workflows:write requirement back to #807. |
.github/workflows/canary-rollout.yml |
Enhances the workflow header docs to list required App permissions and emphasize the grant-and-request nuance. |
| # REQUIRED release-manager App repository permissions (set BOTH on the App AND | ||
| # requested in the token-mint step — `create-github-app-token` restricts the minted | ||
| # token to exactly the `permission-*` it lists, so a grant the step doesn't request | ||
| # is silently absent): |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Dev-Lead — fix-reviews (applied)Changes committed and pushed. |
Documents the full required-permission set for the
petry-projects-release-managerApp in the canary-rollout header and the canary-rings ADR, after #807 established Workflows:write is required for .github tag moves. Emphasizes the grant-AND-request rule. Docs-only.🤖 Generated with Claude Code