Skip to content

fix: pin agent-shield reusable workflow to SHA - #222

Merged
don-petry merged 30 commits into
mainfrom
claude/issue-154-20260420-0033
May 21, 2026
Merged

fix: pin agent-shield reusable workflow to SHA#222
don-petry merged 30 commits into
mainfrom
claude/issue-154-20260420-0033

Conversation

@don-petry

@don-petry don-petry commented Apr 20, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Pins petry-projects/.github/.github/workflows/agent-shield-reusable.yml from @v1 to @ee22b427cbce9ecadcf2b436acb57c3adf0cb63d # v1
  • Resolves the action-pinning compliance finding in the weekly audit

The v1 tag now points to commit ee22b427cbce9ecadcf2b436acb57c3adf0cb63d (it had moved since the previous attempt at PR #178 which used ae9709f4...).

Closes #154

Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Updated continuous integration workflow configuration to use a pinned workflow version for improved consistency and stability.

Pin petry-projects/.github/.github/workflows/agent-shield-reusable.yml
from @v1 to @ee22b427cbce9ecadcf2b436acb57c3adf0cb63d # v1 to satisfy
the action-pinning compliance requirement.

Closes #154

Co-authored-by: don-petry <don-petry@users.noreply.github.com>
Copilot AI review requested due to automatic review settings April 20, 2026 00:34
@don-petry

Copy link
Copy Markdown
Collaborator Author

@don-petry — this PR pins the agent-shield-reusable.yml workflow to its current SHA (ee22b427) to resolve the action-pinning compliance finding in issue #154. Please review and merge when ready.

@coderabbitai

coderabbitai Bot commented Apr 20, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 74f87e3a-8d94-46d5-a072-f6d0eb919bec

📥 Commits

Reviewing files that changed from the base of the PR and between 92719c9 and 391f10b.

📒 Files selected for processing (1)
  • .github/workflows/agent-shield.yml

📝 Walkthrough

Walkthrough

Updated the reusable workflow reference in .github/workflows/agent-shield.yml from a floating tag (@v1) to a pinned commit SHA (@ee22b427cbce9ecadcf2b436acb57c3adf0cb63d), ensuring deterministic workflow execution and compliance with action-pinning standards.

Changes

Cohort / File(s) Summary
GitHub Actions Configuration
.github/workflows/agent-shield.yml
Pinned reusable workflow reference from floating @v1 tag to specific commit SHA for reproducible and compliant workflow execution.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related issues

Possibly related PRs

  • google-app-scripts#146: Both PRs modify the .github/workflows/agent-shield.yml workflow file's reusable-workflow reference, with this PR pinning the previously unpinned reference to a specific commit SHA.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and accurately summarizes the main change: pinning the agent-shield reusable workflow reference to a specific SHA.
Linked Issues check ✅ Passed The pull request successfully addresses issue #154 by pinning the agent-shield reusable workflow from @v1 to the specific commit SHA, achieving full compliance with the action-pinning policy.
Out of Scope Changes check ✅ Passed All changes are directly related to addressing the compliance finding in issue #154; only the workflow reference was modified with no extraneous alterations.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch claude/issue-154-20260420-0033

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Pins the AgentShield reusable workflow reference to an immutable commit SHA to satisfy the org action-pinning compliance standard.

Changes:

  • Update .github/workflows/agent-shield.yml to use petry-projects/.github/.../agent-shield-reusable.yml@ee22b427cbce9ecadcf2b436acb57c3adf0cb63d instead of @v1.

@github-actions
github-actions Bot requested a review from a team as a code owner May 4, 2026 20:39

@donpetry-bot donpetry-bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review — APPROVED ✓

Risk: LOW
Reviewed commit: 654b13368866190edcf4234b23b899f38f691455
Review mode: triage-approved (single reviewer)

Summary

One-line change in .github/workflows/agent-shield.yml that pins the reusable workflow reference from the floating @v1 tag to commit SHA ee22b427cbce9ecadcf2b436acb57c3adf0cb63d (with a # v1 trailing comment for human readability). This is a pure security/compliance improvement — replacing a mutable tag with an immutable SHA reference.

Linked issue analysis

Directly closes #154, an automated compliance-audit finding flagging unpinned-actions-agent-shield.yml (uses: petry-projects/.github/.github/workflows/agent-shield-reusable.yml@v1). The change is exactly the remediation called for by the action-pinning policy in standards/ci-standards.md. The PR description notes that v1 had moved since the previous attempt (#178), and the new SHA reflects the current v1 target — so this supersedes the stale prior attempt.

Findings

  • Scope: isolated to the single uses: line; no other workflow logic changed.
  • Format: @<full-40-char-SHA> # v1 matches the convention recommended by GitHub for pinning while preserving human-readable version context.
  • Correctness: SHA is the full 40-character commit hash, not abbreviated. Pointing to a same-org repo (petry-projects/.github), so supply-chain risk is bounded by org trust.
  • No new findings beyond triage's assessment.

CI status

All required checks passed on the head SHA:

  • CodeQL — Analyze (actions): ✅
  • CodeQL — Analyze (javascript-typescript): ✅
  • CodeQL — Analyze (python): ✅
  • CodeQL: ✅
  • CodeRabbit: ✅
  • SonarQube Cloud Quality Gate: ✅ (0 new issues, 0 security hotspots)

Reviewed automatically by the PR-review agent (single-reviewer mode: opus 4.7). Reply if you need a human review.

@don-petry

Copy link
Copy Markdown
Collaborator Author

@dev-lead - please fix this PR

@sonarqubecloud

Copy link
Copy Markdown

@don-petry
don-petry merged commit 4a5e3f1 into main May 21, 2026
24 of 26 checks passed
@don-petry
don-petry deleted the claude/issue-154-20260420-0033 branch May 21, 2026 08:23
don-petry added a commit that referenced this pull request Aug 4, 2026
Pin petry-projects/.github/.github/workflows/agent-shield-reusable.yml
from @v1 to @ee22b427cbce9ecadcf2b436acb57c3adf0cb63d # v1 to satisfy
the action-pinning compliance requirement.

Closes #154

Co-authored-by: claude[bot] <41898282+claude[bot]@users.noreply.github.com>
Co-authored-by: don-petry <don-petry@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Compliance: unpinned-actions-agent-shield.yml

3 participants