fix: pin agent-shield reusable workflow to SHA - #222
Conversation
|
@don-petry — this PR pins the |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughUpdated the reusable workflow reference in Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related issues
Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
Pins the AgentShield reusable workflow reference to an immutable commit SHA to satisfy the org action-pinning compliance standard.
Changes:
- Update
.github/workflows/agent-shield.ymlto usepetry-projects/.github/.../agent-shield-reusable.yml@ee22b427cbce9ecadcf2b436acb57c3adf0cb63dinstead of@v1.
donpetry-bot
left a comment
There was a problem hiding this comment.
Automated review — APPROVED ✓
Risk: LOW
Reviewed commit: 654b13368866190edcf4234b23b899f38f691455
Review mode: triage-approved (single reviewer)
Summary
One-line change in .github/workflows/agent-shield.yml that pins the reusable workflow reference from the floating @v1 tag to commit SHA ee22b427cbce9ecadcf2b436acb57c3adf0cb63d (with a # v1 trailing comment for human readability). This is a pure security/compliance improvement — replacing a mutable tag with an immutable SHA reference.
Linked issue analysis
Directly closes #154, an automated compliance-audit finding flagging unpinned-actions-agent-shield.yml (uses: petry-projects/.github/.github/workflows/agent-shield-reusable.yml@v1). The change is exactly the remediation called for by the action-pinning policy in standards/ci-standards.md. The PR description notes that v1 had moved since the previous attempt (#178), and the new SHA reflects the current v1 target — so this supersedes the stale prior attempt.
Findings
- Scope: isolated to the single
uses:line; no other workflow logic changed. - Format:
@<full-40-char-SHA> # v1matches the convention recommended by GitHub for pinning while preserving human-readable version context. - Correctness: SHA is the full 40-character commit hash, not abbreviated. Pointing to a same-org repo (
petry-projects/.github), so supply-chain risk is bounded by org trust. - No new findings beyond triage's assessment.
CI status
All required checks passed on the head SHA:
- CodeQL — Analyze (actions): ✅
- CodeQL — Analyze (javascript-typescript): ✅
- CodeQL — Analyze (python): ✅
- CodeQL: ✅
- CodeRabbit: ✅
- SonarQube Cloud Quality Gate: ✅ (0 new issues, 0 security hotspots)
Reviewed automatically by the PR-review agent (single-reviewer mode: opus 4.7). Reply if you need a human review.
|
@dev-lead - please fix this PR |
|
Pin petry-projects/.github/.github/workflows/agent-shield-reusable.yml from @v1 to @ee22b427cbce9ecadcf2b436acb57c3adf0cb63d # v1 to satisfy the action-pinning compliance requirement. Closes #154 Co-authored-by: claude[bot] <41898282+claude[bot]@users.noreply.github.com> Co-authored-by: don-petry <don-petry@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>



Summary
petry-projects/.github/.github/workflows/agent-shield-reusable.ymlfrom@v1to@ee22b427cbce9ecadcf2b436acb57c3adf0cb63d # v1The
v1tag now points to commitee22b427cbce9ecadcf2b436acb57c3adf0cb63d(it had moved since the previous attempt at PR #178 which usedae9709f4...).Closes #154
Generated with Claude Code
Summary by CodeRabbit