Skip to content

rollout: deploy pr-review-mention standard workflow - #353

Merged
don-petry merged 105 commits into
mainfrom
rollout/pr-review-mention-19241
May 31, 2026
Merged

rollout: deploy pr-review-mention standard workflow#353
don-petry merged 105 commits into
mainfrom
rollout/pr-review-mention-19241

Conversation

@don-petry

@don-petry don-petry commented May 31, 2026

Copy link
Copy Markdown
Collaborator

Deploy standard pr-review-mention.yml workflow from petry-projects/.github standards. This enables PR review mentions to trigger the org-level review agent.

Summary by CodeRabbit

  • Chores
    • CI workflow behavior and permissions remain unchanged; no user-facing automation changes.
    • Repository ignore rules updated to add development-tooling entries (some duplicates), reducing noise from local/dev files.

Copilot AI review requested due to automatic review settings May 31, 2026 03:53
@don-petry
don-petry requested a review from a team as a code owner May 31, 2026 03:53
@coderabbitai

coderabbitai Bot commented May 31, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@don-petry, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 16 minutes and 33 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 33518047-af22-452a-980e-a4db915cf49b

📥 Commits

Reviewing files that changed from the base of the PR and between cfa571e and 71a421a.

📒 Files selected for processing (1)
  • .gitignore
📝 Walkthrough

Walkthrough

The CI workflow file is unchanged and still delegates to a reusable workflow; .gitignore gains repeated .dev-lead/ ignore entries to exclude development tool artifacts.

Changes

Build and Ignore Configuration

Layer / File(s) Summary
CI Workflow File
.github/workflows/pr-review-mention.yml
Workflow file content is unchanged; it continues to trigger on issue comments, review comments, and review requests while delegating to the reusable workflow with inherited secrets.
Development Ignore Patterns
.gitignore
Multiple .dev-lead/ directory ignore entries were added to .gitignore (lines 11–22).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly describes the main change: deploying a standard pr-review-mention workflow, which aligns with the file modifications and PR objectives.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch rollout/pr-review-mention-19241

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@gemini-code-assist

Copy link
Copy Markdown

Note

Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adopts the org-standard pr-review-mention.yml thin caller workflow so that PR review mentions in this repo dispatch to the centralized reusable workflow in petry-projects/.github. The change strips the prior AGENTS header banner and switches the uses: reference from a commit-SHA pin to the floating @v2 tag.

Changes:

  • Remove the "AGENTS — READ BEFORE EDITING" header documenting this file as a thin caller stub.
  • Change the reusable workflow reference from a SHA pin (@376a4fc… # v2) to the mutable tag @v2.
  • Add a trailing blank line at end of file.

Comment thread .github/workflows/pr-review-mention.yml Outdated
Comment thread .github/workflows/pr-review-mention.yml
Comment thread .github/workflows/pr-review-mention.yml Outdated
@don-petry

Copy link
Copy Markdown
Collaborator Author

Dev-Lead — review-changes (applied)

Changes committed and pushed.

@github-actions

Copy link
Copy Markdown
Contributor

CI Failure: SonarCloud Code Analysis

Step: SonarCloud Quality Gate
Root cause: Config error

The PR replaces a pinned commit SHA (@376a4fcb1117444595e3e702fa450873d0e54310) with a mutable tag (@v2) in .github/workflows/pr-review-mention.yml. SonarCloud flags this because mutable tags can silently change what code runs in CI, violating its security quality gate for supply-chain integrity. Pinned SHAs guarantee the exact version of external workflows being invoked.

Suggested fix: Revert the uses: reference back to the pinned SHA: uses: petry-projects/.github/.github/workflows/pr-review-mention-reusable.yml@376a4fcb1117444595e3e702fa450873d0e54310 # v2

View run logs

@don-petry

Copy link
Copy Markdown
Collaborator Author

Dev-Lead — review-changes (applied)

Changes committed and pushed.

@github-actions

Copy link
Copy Markdown
Contributor

CI Failure: SonarCloud Code Analysis

Step: SonarCloud Quality Gate
Root cause: Config error

The PR changes .github/workflows/pr-review-mention.yml to use a mutable tag reference (@v2) instead of a pinned commit SHA (@376a4fcb1117444595e3e702fa450873d0e54310) for the reusable workflow. SonarCloud flags this as a security vulnerability (unpinned third-party action) because a mutable tag can be silently updated to point to different — potentially malicious — code. Additionally, .gitignore now contains a duplicate .dev-lead/ entry, which is a minor code smell. The quality gate likely failed because the unpinned action reference introduces a new security hotspot that pushes the project below the configured threshold.

Suggested fix: Restore the pinned commit SHA in the uses: line — change @v2 back to @376a4fcb1117444595e3e702fa450873d0e54310 # v2 — and remove the duplicate .dev-lead/ line from .gitignore.

View run logs

@don-petry

Copy link
Copy Markdown
Collaborator Author

Dev-Lead — review-changes (applied)

Changes committed and pushed.

@github-actions

Copy link
Copy Markdown
Contributor

CI Failure: SonarCloud Code Analysis

Step: SonarCloud Code Analysis
Root cause: Config error

The PR changed .github/workflows/pr-review-mention.yml to replace a pinned commit SHA (@376a4fcb1117444595e3e702fa450873d0e54310) with a mutable floating tag (@v2). SonarCloud flags this as a supply chain security vulnerability (CWE-829): using a floating tag means the referenced workflow can be silently changed by the upstream repo owner, exposing the pipeline to malicious code injection. Additionally, .gitignore gained three duplicate .dev-lead/ entries, which may trigger a code smell finding.

Suggested fix: Revert the uses: line in pr-review-mention.yml to pin the reusable workflow to its full-length commit SHA — e.g., uses: petry-projects/.github/.github/workflows/pr-review-mention-reusable.yml@376a4fcb1117444595e3e702fa450873d0e54310 # v2 — and remove the two duplicate .dev-lead/ lines added to .gitignore.

View run logs

@don-petry

Copy link
Copy Markdown
Collaborator Author

Dev-Lead — review-changes (applied)

Changes committed and pushed.

@github-actions

Copy link
Copy Markdown
Contributor

CI Failure: SonarCloud Code Analysis

Step: SonarCloud Code Analysis (external quality gate)
Root cause: Config error

The PR changed .github/workflows/pr-review-mention.yml to replace a pinned commit SHA (376a4fcb1117444595e3e702fa450873d0e54310) with a floating tag reference (@v2) on the reusable workflow uses: line. SonarCloud flags unpinned GitHub Actions references as a supply-chain security vulnerability (CWE-829), because a floating tag can silently be redirected to malicious code without any diff. Additionally, .gitignore now contains four duplicate .dev-lead/ entries, which SonarCloud registers as code duplication/smell.

Suggested fix: Restore the pinned SHA in the uses: line — change @v2 back to @376a4fcb1117444595e3e702fa450873d0e54310 — and remove the three redundant .dev-lead/ lines from .gitignore.

View run logs

@don-petry

Copy link
Copy Markdown
Collaborator Author

Dev-Lead — review-changes (applied)

Changes committed and pushed.

@github-actions

Copy link
Copy Markdown
Contributor

CI Failure: SonarCloud Code Analysis

Step: SonarCloud Quality Gate
Root cause: Config error

The PR replaces a pinned commit SHA (@376a4fcb1117444595e3e702fa450873d0e54310) with a floating tag (@v2) for the reusable workflow reference in pr-review-mention.yml. SonarCloud flags this as a security vulnerability: unpinned third-party actions can be silently mutated to introduce malicious code (supply-chain attack). Additionally, .gitignore has the .dev-lead/ entry duplicated five times, which is a code smell SonarCloud may also surface.

Suggested fix: Revert the uses: line in .github/workflows/pr-review-mention.yml back to the pinned SHA form: uses: petry-projects/.github/.github/workflows/pr-review-mention-reusable.yml@376a4fcb1117444595e3e702fa450873d0e54310 # v2, and remove the four duplicate .dev-lead/ lines from .gitignore.

View run logs

@don-petry

Copy link
Copy Markdown
Collaborator Author

Dev-Lead — review-changes (applied)

Changes committed and pushed.

@github-actions

Copy link
Copy Markdown
Contributor

CI Failure: SonarCloud Code Analysis

Step: SonarCloud Quality Gate
Root cause: Config error

The PR introduces two configuration problems that SonarCloud flags as quality issues. First, .gitignore has five duplicate .dev-lead/ entries added, which SonarCloud treats as code smell / redundant code. Second, pr-review-mention.yml replaces a pinned immutable commit SHA (376a4fcb...) with a mutable floating tag (@v2), which SonarCloud flags as a security hotspot — mutable tags can be silently redirected to a different commit.

Suggested fix: Remove the five duplicate .dev-lead/ lines from .gitignore (keep only the one already present before this PR) and restore the pinned SHA reference in the uses: field of pr-review-mention.yml (petry-projects/.github/.github/workflows/pr-review-mention-reusable.yml@376a4fcb1117444595e3e702fa450873d0e54310 # v2).

View run logs

@don-petry

Copy link
Copy Markdown
Collaborator Author

Dev-Lead — review-changes (applied)

Changes committed and pushed.

@don-petry

Copy link
Copy Markdown
Collaborator Author

Dev-Lead — review-changes (applied)

Changes committed and pushed.

@don-petry

Copy link
Copy Markdown
Collaborator Author

Dev-Lead — review-changes (applied)

Changes committed and pushed.

@don-petry

Copy link
Copy Markdown
Collaborator Author

Dev-Lead — review-changes (applied)

Changes committed and pushed.

@don-petry

Copy link
Copy Markdown
Collaborator Author

Dev-Lead — review-changes (applied)

Changes committed and pushed.

@don-petry

Copy link
Copy Markdown
Collaborator Author

Dev-Lead — review-changes (applied)

Changes committed and pushed.

@don-petry

Copy link
Copy Markdown
Collaborator Author

Dev-Lead — review-changes (applied)

Changes committed and pushed.

@don-petry

Copy link
Copy Markdown
Collaborator Author

Dev-Lead — review-changes (applied)

Changes committed and pushed.

@don-petry

Copy link
Copy Markdown
Collaborator Author

Dev-Lead — review-changes (applied)

Changes committed and pushed.

@don-petry

Copy link
Copy Markdown
Collaborator Author

Dev-Lead — review-changes (applied)

Changes committed and pushed.

@don-petry

Copy link
Copy Markdown
Collaborator Author

Dev-Lead — review-changes (applied)

Changes committed and pushed.

@don-petry

Copy link
Copy Markdown
Collaborator Author

Dev-Lead — review-changes (applied)

Changes committed and pushed.

@don-petry

Copy link
Copy Markdown
Collaborator Author

Dev-Lead — review-changes (applied)

Changes committed and pushed.

@don-petry

Copy link
Copy Markdown
Collaborator Author

Dev-Lead — review-changes (applied)

Changes committed and pushed.

@sonarqubecloud

Copy link
Copy Markdown

@don-petry
don-petry merged commit 2cac3bf into main May 31, 2026
23 of 24 checks passed
@don-petry
don-petry deleted the rollout/pr-review-mention-19241 branch May 31, 2026 11:56
@github-actions

Copy link
Copy Markdown
Contributor

CI Failure: SonarCloud Code Analysis

Step: SonarCloud Quality Gate
Root cause: Config error

The PR introduces 46 duplicate .dev-lead/ entries into .gitignore, which SonarCloud likely flags as a code smell or duplicate-code violation causing the quality gate to fail. Additionally, the meaningful agent-guidance comments were stripped from .github/workflows/pr-review-mention.yml, removing documentation that guards against misconfiguration. SonarCloud quality gates fail when new issues push the project below configured thresholds for duplications or code smells.

Suggested fix: Edit .gitignore to remove the 46 duplicate .dev-lead/ lines, leaving only the single existing entry that was already present before this PR.

View run logs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants