Skip to content

feat: implement issue #449 — Compliance: stub-surface-drift-feature-ideation.yml-on - #478

Merged
don-petry merged 1 commit into
mainfrom
dev-lead/issue-449-20260722-0813
Jul 22, 2026
Merged

feat: implement issue #449 — Compliance: stub-surface-drift-feature-ideation.yml-on#478
don-petry merged 1 commit into
mainfrom
dev-lead/issue-449-20260722-0813

Conversation

@don-petry

@don-petry don-petry commented Jul 22, 2026

Copy link
Copy Markdown
Collaborator

User description

Closes #449

Implemented by dev-lead agent. Please review.


CodeAnt-AI Description

Keep the feature ideation workflow stable during formatting

What Changed

  • Marked the feature ideation workflow as off-limits for Prettier so its workflow settings stay byte-identical and do not drift over time
  • Kept the manual input description for the backlog enhancement sweep intact by switching it to a safer quoted form

Impact

✅ Fewer broken workflow syncs
✅ Lower risk of accidental workflow drift
✅ More reliable feature ideation runs

💡 Usage Guide

Checking Your Pull Request

Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.

Talking to CodeAnt AI

Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:

@codeant-ai ask: Your question here

This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.

Example

@codeant-ai ask: Can you suggest a safer alternative to storing this secret?

Preserve Org Learnings with CodeAnt

You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:

@codeant-ai: Your feedback here

This helps CodeAnt AI learn and adapt to your team's coding style and standards.

Example

@codeant-ai: Do not flag unused imports.

Retrigger review

Ask CodeAnt AI to review the PR again, by typing:

@codeant-ai: review

Check Your Repository Health

To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.

@don-petry
don-petry requested a review from a team as a code owner July 22, 2026 08:17
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@codeant-ai

codeant-ai Bot commented Jul 22, 2026

Copy link
Copy Markdown

🤖 CodeAnt AI — Review Status

Status Commit Started (UTC) Finished (UTC)
✅ Reviewed your PR 012406c Jul 22, 2026 · 08:18 08:19

Updated in place by CodeAnt AI · last 5 reviews

@coderabbitai

coderabbitai Bot commented Jul 22, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 05193b7a-a130-4b94-a4c5-5cefee891678

📥 Commits

Reviewing files that changed from the base of the PR and between 2148a86 and 012406c.

📒 Files selected for processing (2)
  • .github/workflows/feature-ideation.yml
  • .prettierignore

📝 Walkthrough

Walkthrough

The workflow dispatch description’s YAML quoting was changed without altering behavior, and .prettierignore now excludes the workflow to preserve its canonical byte-level format.

Changes

Workflow formatting preservation

Layer / File(s) Summary
Description quoting and formatting guard
.github/workflows/feature-ideation.yml, .prettierignore
The enhance_backlog description uses updated quoting, and the workflow is excluded from Prettier formatting.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related issues

  • None identified.

Possibly related PRs

Suggested reviewers: donpetry-bot

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Linked Issues check ⚠️ Warning The PR does not re-sync the workflow's on/permissions/concurrency surface; it only tweaks a description and adds a prettier ignore entry. Copy .github/workflows/feature-ideation.yml from standards/workflows/feature-ideation.yml verbatim, preserving on:, permissions:, and concurrency:.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title is specific and directly references the compliance issue and workflow stub it affects.
Out of Scope Changes check ✅ Passed The changes stay focused on the feature-ideation workflow and related formatter handling, with no clear unrelated additions.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch dev-lead/issue-449-20260722-0813

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the .prettierignore file to exclude .github/workflows/feature-ideation.yml from Prettier formatting. This prevents formatting changes, such as rewriting single-quoted YAML scalars to double quotes, which would cause byte-drift against the centrally-owned template. There are no review comments, and I have no additional feedback to provide.

@codeant-ai codeant-ai Bot added the size:XS This PR changes 0-9 lines, ignoring generated files label Jul 22, 2026
@qodo-code-review

Copy link
Copy Markdown

PR Summary by Qodo

Prevent Prettier from reintroducing stub-surface drift in feature-ideation workflow

⚙️ Configuration changes 🕐 Less than 10 minutes

Grey Divider

AI Description

• Align feature-ideation workflow YAML quoting to match the standards-owned canonical stub.
• Exclude feature-ideation workflow stub from Prettier to prevent byte-level surface drift.
• Document why the file must remain byte-identical for the stub-drift guard.
High-Level Assessment

The following are alternative approaches to this PR:

1. Prettier override (YAML quoting) instead of ignoring the file
  • ➕ Keeps the workflow formatted by Prettier while still matching canonical quoting
  • ➕ Avoids growing the ignore list as more standards-owned stubs are added
  • ➖ Prettier/YAML tooling may not reliably preserve exact scalar style across versions/plugins
  • ➖ Does not guarantee byte-identical output, which the drift guard enforces
2. Change drift guard to semantic YAML comparison
  • ➕ Allows formatting differences while still ensuring equivalent workflow behavior
  • ➕ Reduces friction with formatting tools like Prettier
  • ➖ Significantly more complex guard logic (needs canonicalization rules)
  • ➖ May miss intentional surface-shape constraints that are currently enforced byte-identical
3. Generate stubs during CI sync rather than storing verbatim copies
  • ➕ Eliminates local formatting drift by making files generated artifacts
  • ➕ Centralizes canonical content management
  • ➖ Introduces generation tooling and developer workflow changes
  • ➖ Still needs a robust mechanism to detect/handle local edits

Recommendation: Given the guard’s explicit requirement for byte-identical on/permissions/concurrency surfaces, ignoring the stub in Prettier is the most reliable and lowest-maintenance approach. Prettier overrides and semantic drift checks can be considered later if the org decides to relax byte-identity enforcement.

Files changed (2) +7 / -1

Other (2) +7 / -1
feature-ideation.ymlNormalize YAML quoting to match canonical feature-ideation stub +1/-1

Normalize YAML quoting to match canonical feature-ideation stub

• Replaces a double-quoted input description with a single-quoted YAML scalar that matches the standards-owned canonical workflow stub. This prevents formatting-driven surface drift for a field that is byte-compared by the stub-drift guard.

.github/workflows/feature-ideation.yml

.prettierignoreIgnore feature-ideation workflow stub to avoid byte-drift +6/-0

Ignore feature-ideation workflow stub to avoid byte-drift

• Adds '.github/workflows/feature-ideation.yml' to the Prettier ignore list with rationale. This prevents Prettier from rewriting YAML scalar quoting and reintroducing drift against the centrally-managed standard.

.prettierignore

@sonarqubecloud

Copy link
Copy Markdown

@don-petry

Copy link
Copy Markdown
Collaborator Author

Dev-Lead — waiting on PR blockers (intent: review-changes)

PR: #478
No changes were committed, but the PR still has blocking checks or reviews (failing or cancelled checks, or changes-requested reviews). The retry cron will re-attempt automatically. Next attempt after: 2026-07-22T08:49:22Z

@don-petry

Copy link
Copy Markdown
Collaborator Author

Note

@don-petry I reviewed this PR and no code changes were needed, but it still has blocking checks or reviews (failing or cancelled checks, or changes-requested reviews), so I cannot mark it done yet. I'll re-check automatically.
Next attempt after: 2026-07-22T08:49:22Z

@don-petry
don-petry enabled auto-merge (squash) July 22, 2026 08:19
@qodo-code-review

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Grey Divider

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Grey Divider

Qodo Logo

@donpetry-bot donpetry-bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review — APPROVED ✓

Risk: LOW
Reviewed commit: 012406ca70b1ce5edf5b6bd26439f38cdeaa6997
Review mode: triage-approved (single reviewer)

Summary

XS compliance fix (+7/-1, 2 files) resolving issue #449 stub-surface drift. Re-quotes one workflow_dispatch input description in .github/workflows/feature-ideation.yml from double to single quotes (identical string value, zero semantic change) to match the canonical standards/workflows/feature-ideation.yml, and adds the file to .prettierignore so Prettier cannot re-introduce the drift. Verified at head SHA: the enforced on:/permissions:/concurrency: surface is now byte-identical to the canonical template; remaining diffs are only in permitted per-repo areas (with: inputs, tier channel pin).

Linked issue analysis

Issue #449 (compliance-audit, severity error) reports that the feature-ideation.yml caller stub's on: surface drifted from standards/workflows/feature-ideation.yml. Verified fix: fetched the canonical template and the PR head file and diffed the on:/permissions:/concurrency: blocks — they are byte-identical after this change. The .prettierignore addition addresses the root cause (Prettier rewriting single-quoted YAML scalars to double quotes), following the existing precedent for initiative-driver.yml. Issue is substantively addressed.

Findings

No blocking findings.

  • Workflow change is formatting-only: YAML double-quoted to single-quoted scalar with identical value; no changes to triggers, permissions, concurrency, actions, or run steps — no GitHub Actions security smells.
  • .prettierignore entry is well-commented and mirrors the established pattern for initiative-driver.yml.
  • Trade-off (non-blocking): the entire workflow file is now exempt from Prettier, so future formatting issues in it will not be auto-fixed — acceptable since the file is standards-owned and synced verbatim.
  • Secret scan: run_secret_scanning MCP tool not available in this environment; gitleaks CI check passed and the diff contains no secret-like content.
  • No unresolved review threads; all PR comments are from bots (CodeAnt, CodeRabbit, Qodo, Sonar, gemini) with no blocking findings and no unanswered human questions.

CI status

All code checks green: build-and-test, Node.js Tests, Playwright UI Tests, coverage, autofix, CodeQL (actions/js-ts/python), SonarCloud (quality gate passed), Secret scan (gitleaks), dependency-audit (npm audit pass, others skipped), agent-shield, CodeRabbit. Two non-code entries show cancelled/failed: dev-lead / dispatch and dev-lead / ci-relay from a single pull_request_review-triggered Dev-Lead agent orchestration run that was rate-limited (per its own PR comment, retry after 08:49Z) — superseded by a passing dev-lead / dispatch run at the same SHA. These are agent-orchestration plumbing, not code verification.


Reviewed automatically by the PR-review agent (single-reviewer mode: fable 5). Reply if you need a human review.

@don-petry
don-petry merged commit 9973619 into main Jul 22, 2026
30 of 32 checks passed
@don-petry
don-petry deleted the dev-lead/issue-449-20260722-0813 branch July 22, 2026 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS This PR changes 0-9 lines, ignoring generated files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Compliance: stub-surface-drift-feature-ideation.yml-on

2 participants