Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/add-to-project.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
# • This file is a THIN CALLER STUB. All noise-gate / reconcile logic lives
# in the reusable workflow above.
# • You MAY change: nothing in normal use. The `uses:` ref and `agent_ref`
# are pinned to the `add-to-project/stable` channel and move with it — do
# are pinned to the `add-to-project/v1-stable` channel and move with it — do
# not change them to `@main` or a SHA (see ci-standards.md → Reusable
# workflow versioning).
# • You MUST NOT change: trigger events, the concurrency group, or the
Expand Down Expand Up @@ -47,7 +47,7 @@ jobs:
add-to-project:
permissions:
contents: read
uses: petry-projects/.github/.github/workflows/add-to-project-reusable.yml@add-to-project/stable # NOSONAR(githubactions:S7637) first-party channel ref
uses: petry-projects/.github/.github/workflows/add-to-project-reusable.yml@add-to-project/v1-stable # NOSONAR(githubactions:S7637) first-party channel ref
with:
project_id: PVT_kwDOD2inqs4BZq3-
project_url: https://github.com/orgs/petry-projects/projects/1
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/feature-ideation.yml
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,7 @@ jobs:
discussions: write
id-token: write
actions: read
uses: petry-projects/.github/.github/workflows/feature-ideation-reusable.yml@feature-ideation/stable # NOSONAR(githubactions:S7637) first-party channel ref
uses: petry-projects/.github/.github/workflows/feature-ideation-reusable.yml@feature-ideation/v1-stable # NOSONAR(githubactions:S7637) first-party channel ref
with:
# All values below come from `needs.prep.outputs.*` (resolved in the `prep`
# job) — NOT the `inputs` context — so this reusable `with:` compiles on the
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/initiative-driver.yml
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ jobs:
GH_TOKEN: ${{ secrets.GH_PAT_DON_PETRY || secrets.GH_PAT_WORKFLOWS }}
Comment thread
don-petry marked this conversation as resolved.
run: |
if [ -z "${GH_TOKEN}" ]; then
echo "::error::Either GH_PAT_DON_PETRY or GH_PAT_WORKFLOWS is required — a workflow_dispatch fired with GITHUB_TOKEN never starts a run."
echo "::error::GH_PAT_WORKFLOWS is required — a workflow_dispatch fired with GITHUB_TOKEN never starts a run."
exit 1
fi

Expand Down
37 changes: 17 additions & 20 deletions .github/workflows/pr-auto-review.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,17 +6,17 @@
# AGENTS — READ BEFORE EDITING:
# • This file is a THIN CALLER STUB. All readiness-gate logic lives in the
# reusable workflow above.
# • You MAY change: the tag in the `uses:` line when upgrading the reusable
# workflow version (e.g. bump `@v2` → `@v3` when petry-projects/.github cuts
# a new release), and the workflow name(s) in `workflow_run.workflows` to
# match your repository's CI workflow name(s).
# • You MUST NOT change: trigger event types or the job-level `permissions:`
# block — reusable workflows can be granted no more permissions than the
# calling job, so removing the stanza breaks the reusable's gh API calls.
# • You MAY change: the workflow name(s) in `workflow_run.workflows` to match
# your repository's CI workflow name(s).
# • You MUST NOT change: the `@pr-auto-review/v1-stable` channel in the `uses:`
# line — this reusable is on the org-wide moving-channel model (rollout and
# rollback are a single central tag move; a frozen `@vN`/`@<sha>` pin is
# rejected by the compliance audit). Nor the trigger event types or the
# job-level `permissions:` block — reusable workflows can be granted no more
# permissions than the calling job, so removing the stanza breaks the
# reusable's gh API calls.
# • If you need different behaviour, open a PR against the reusable in the
# central repo.
# • When publishing a new version of this reusable, also update this template
# and open a fanout PR across all caller repos.
# central repo. The change will propagate everywhere on next run.
# ─────────────────────────────────────────────────────────────────────────────
#
# PR Auto-Review — thin caller for the org-level reusable.
Expand All @@ -28,8 +28,9 @@
# workflow_run fires when a named GitHub Actions workflow completes.
# check_suite does NOT trigger for GitHub Actions runs, so this is required
# to catch CI turning green on a PR.
# TODO: replace "CI" with your repository's CI workflow name(s).

Check warning on line 31 in .github/workflows/pr-auto-review.yml

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Complete the task associated to this "TODO" comment.

See more on https://sonarcloud.io/project/issues?id=petry-projects_google-app-scripts&issues=AZ-JpKggZMTtFQv1wpFv&open=AZ-JpKggZMTtFQv1wpFv&pullRequest=479
Comment thread
don-petry marked this conversation as resolved.
workflow_run:
workflows: ['Node.js Tests', 'CI Pipeline']
workflows: ["CI"]
types: [completed]
# check_suite covers third-party CI checks (e.g. SonarCloud, external apps).
check_suite:
Expand All @@ -45,17 +46,13 @@

jobs:
Comment thread
don-petry marked this conversation as resolved.
pr-auto-review:
# Skip fork PRs on pull_request and pull_request_review events — forks don't
# receive org secrets, so GH_PAT_WORKFLOWS would be empty and the reusable's
# gh api calls would fail. Other triggers (workflow_run, check_suite) always
# run in the base-repo context and have full secret access.
if: >
(github.event_name != 'pull_request' && github.event_name != 'pull_request_review') ||
github.event.pull_request.head.repo.fork == false
permissions:
pull-requests: read
checks: read
actions: read
uses: petry-projects/.github/.github/workflows/pr-auto-review-reusable.yml@pr-auto-review/stable # NOSONAR(githubactions:S7637) first-party channel ref
uses: petry-projects/.github/.github/workflows/pr-auto-review-reusable.yml@pr-auto-review/v1-stable # NOSONAR(githubactions:S7637) first-party channel ref
secrets:
GH_PAT_WORKFLOWS: ${{ secrets.GH_PAT_WORKFLOWS }}
# Canonical-first fallback (.github-private#1326). The reusable resolves this
# secret BY NAME, so only the VALUE changes — the passed key stays named
# GH_PAT_WORKFLOWS.
GH_PAT_WORKFLOWS: ${{ secrets.GH_PAT_DON_PETRY || secrets.GH_PAT_WORKFLOWS }}
Loading