Implement login protection#282
Merged
Merged
Conversation
adds the enable_login_protection field to the api ui page and /api/v1/system/api. this field toggles enabling login protection for api authentication. this will help prevent brute force attacks against api endpoints
on the api ui page, we were evaluating a base variable which erroneously set or unset the variable
login protection requires the username to be set in order to work. this sets the default username to 'unknown' if no username could be found
before the test_login_protection test expected requests to start failing at a specific point, but this does not work with all login protection configs and situations. it now just expects the requests to start to timeout after many failed auth attempts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.