reload config issue

[liujinyang-highgo]

hi，
I met an issue ，could you help have a look at it?

reproduce:

1. set parameter log_connections(default value is off) to on in ppgool.conf
   log_connections = on
2. then use psql connect to pgpool and run show command.

    ppgool show log_connections;  
    log_connections 
   -----------------
    on

3. \q and terminate the connection.
4. comment this parameter in pgpool.conf.
   # log_connections = on
5. do reload
   ./pgpool -f ../etc/pgpool.conf reload
6. use psql connect to pgpool again and run show command.

    ppgool show log_connections;  
    log_connections 
   -----------------
    on

my concern:
for my understanding, in step 6, the result should be recovered to default value? right?
I checked code, when parent process received reload sig, it will send this sig to all child processes, then child call check_config_reload()->pool_get_config() to reload config file, but it will ignore commented lines in pgpool.conf, so the commented lines would not be recovered to default value.
I'm not quite sure if this is the original design intention.

Thanks a lot!

[koshino-235]

Hi,

I can reproduce this behavior in my environment.

Commenting out a parameter and reloading does not restore it to its default value.
This is the current behavior.

However, this is not the behavior the development team intended, and we're planning to fix it.

As a workaround, either:

• keep the parameter uncommented, set it explicitly to its default value, and reload.
• comment it out and restart Pgpool-II so the default value is applied at startup.