Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @phaag 👋,
Recently working with nfdump, I notice that sometimes when using the nfexpire tool, we can't be so sure how many files we'll delete using the arguments, so I tried to implement a new option to first make a dry-run, where will be possible to see which files and folders that will be deleted before executing it. Here are some examples:
Environment:
dry-run mode:
executing the expire:
dry-run showing the folder that would be deleted too:
I've updated the manual including the new -n option with some examples:
Let me know your thoughts for this new feature.
Kind regards,
Murilo Chianfa