Skip to content

Upgrade gradle and lib versions. #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
orian wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Upgrade gradle and lib versions. #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@ language: android

android:
components:
- build-tools-22.0.1
- android-22
- build-tools-23.0.2
- android-23
- extra-android-support
- extra-android-m2repository

Expand Down
16 changes: 9 additions & 7 deletions app/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ buildscript {

}
dependencies {
classpath 'com.neenbedankt.gradle.plugins:android-apt:1.4'
classpath 'com.neenbedankt.gradle.plugins:android-apt:1.8'
}
}

Expand All @@ -20,14 +20,15 @@ android {
storePassword 'release'
}
}
compileSdkVersion 22
buildToolsVersion "22.0.1"
compileSdkVersion 23
buildToolsVersion "23.0.2"
defaultConfig {
applicationId "net.pawelhajduk.daggerdemo"
minSdkVersion 15
targetSdkVersion 22
targetSdkVersion 23
versionCode 1
versionName "1.0"
multiDexEnabled true
Copy link
Copy Markdown
Owner

@phajduk phajduk Apr 8, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did we exceed 64k? 😱

Copy link
Copy Markdown
Author

@orian orian Apr 8, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

However crazy it sounds: debug mode + new version of dagger and appcompat was causing the app to miserably crash on Nexus 5 ;-) Googling revealed that the problem is 64k ;-)

I guess it should be possible to enable multidex in debug and disable in prod?

}
buildTypes {
release {
Expand All @@ -46,10 +47,11 @@ android {

dependencies {
provided 'javax.annotation:jsr250-api:1.0'
compile 'com.google.dagger:dagger-compiler:2.0.2'
compile 'com.google.dagger:dagger:2.0.2'
apt 'com.google.dagger:dagger-compiler:2.1'
compile 'com.google.dagger:dagger:2.1'
compile fileTree(include: ['*.jar'], dir: 'libs')
compile 'com.android.support:appcompat-v7:22.2.0'
compile 'com.android.support:appcompat-v7:23.1.1'
compile 'com.android.support:multidex:1.0.1'
compile 'com.jakewharton:butterknife:7.0.1'
compile 'com.squareup.retrofit:retrofit:1.9.0'
compile 'com.squareup.retrofit:retrofit-mock:1.9.0'
Expand Down
4 changes: 2 additions & 2 deletions app/src/main/java/net/pawelhajduk/daggerdemo/DaggerDemoApplication.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
package net.pawelhajduk.daggerdemo;

import android.app.Application;
import android.support.multidex.MultiDexApplication;

public class DaggerDemoApplication extends Application {
public class DaggerDemoApplication extends MultiDexApplication {
private static DaggerDemoGraph graph;
private static DaggerDemoApplication instance;

Expand Down
3 changes: 2 additions & 1 deletion app/src/main/java/net/pawelhajduk/daggerdemo/MainActivity.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
import android.content.res.Resources;
import android.os.Bundle;
import android.support.v7.app.ActionBarActivity;
import android.support.v7.app.AppCompatActivity;
import android.widget.CheckBox;
import android.widget.CompoundButton;
import android.widget.TextView;
Expand All @@ -19,7 +20,7 @@
import butterknife.OnCheckedChanged;
import butterknife.OnClick;

public class MainActivity extends ActionBarActivity {
public class MainActivity extends AppCompatActivity {
@Bind(R.id.main_tv_text)
TextView text;

Expand Down
2 changes: 1 addition & 1 deletion build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ buildscript {
jcenter()
}
dependencies {
classpath 'com.android.tools.build:gradle:1.2.3'
classpath 'com.android.tools.build:gradle:1.5.0'
}
}

Expand Down