[Debugger] Improving skipUpTo stability + reintegration in the advanced debugging tools #415
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… empty (if there's only a caret) + reintegration in the advanced debugging tools
Contributor
Author
|
It doesn't look like the failing test is related |
MarcusDenker
approved these changes
Sep 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
skipUpTo command was very unstable and could easily make an image freeze. However, it has been improved a lot via a bunch of PRs in https://github.com/pharo-spec/ScriptableDebugger.
The only PR that needs to be integrated to make it completely stable is this one: pharo-spec/ScriptableDebugger#48. Then, I believe that this could be integrated again in the debugger and that's why I make this PR as some people like @labordep and @astares are interested in this feature.
I also improved the command to make it more intuitive as, until now, the user had to select a message send or an assignment to skip up to this instruction, otherwise it would skip everything. I improved it so that putting a caret before a message send or assignment (or anything else) allows the user to skip up to this instruction.
This PR could be merged after pharo-spec/ScriptableDebugger#48 is merged.