When enabling #timesRepeat: to be optimised, fail: SindarinCommandsTest>>testStepToNextCallInClassNeverFinishes

[MarcusDenker]

I would like to enable #timesRepea: to compile as an optimized construct by default

(see pharo-project/pharo#11439)

But SindarinCommandsTest>>testStepToNextCallInClassNeverFinishes relies on the method to be not optimised.

A minimal change would be to have it for now as

acceptVisitorNeverFinishes: aVisitor
	<compilerOptions: #(- optionInlineTimesRepeat)>
	10000 timesRepeat: [ self doStuff ]

How to change that so that we get it in Pharo11?

Somehow the package is neither really external nor internal, that is, I have no idea how to commit a change.

[adri09070]

Somehow the package is neither really external nor internal, that is, I have no idea how to commit a change.

Actually, this is a real problem for me too. I commit changes on the master branch but it is not synchronised with the Pharo repository.

On the other side, some changes were done a year and a half ago in the Pharo repository and these changes were merged into the Pharo 10 branch in this repository but not into the master branch...

So, I think the way to go is:

• to merge into the master branch the changes that were merged into the Pharo 10 branch: Prepare for #realActiveProcess integration in Pharo #14
• to checkout branch from master to create a Pharo 11 branch
• to change whatever it is used by Pharo to import Sindarin so that it imports the Sindarin package from the new Pharo 11 branch.

But actually, I don't know how Pharo imports Sindarin... I see that some changes in Sindarin were done in the Pharo repository, for example here: pharo-project/pharo#8567
But I can"t find the Sindarin package now!
So I think that a baseline somewhere imports ScriptableDebugger:Pharo10

[adri09070]

I found where Sindarin is imported! @MarcusDenker

It's imported from

BaselineOfNewTools>>#sindarin:

So you can do the changes I suggested above and modify the URL in this method in NewTools

[MarcusDenker]

Great! I will do that.

[adri09070]

The synch is going to be done in NewTools: pharo-spec/NewTools#393.

You can do a PR in this repo into the master branch and then we will do a PR from the master branch into the Pharo-11 branch.

[MarcusDenker]

In the end this was in the NewTools package....

pharo-spec/NewTools#394

[MarcusDenker]

I merged the PR