Fixing unitary skip command in Pharo 11 #47
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…value is pushed on the top of the stack only when a storeInto bytecode is involved
…d of putting nil + test and fixing existing tests
…mplicit returns + adding tests for that
… of a method in RBBlockDefinitionSearchingVisitor class
…g-value-on-the-stack-when-storeInto-bytecodes-are-involved Fixing skipAssignment command that wasn't pushing the assignment value when it was expected + test
…-puts-nil-on-stack Fixing skip command so that it leaves the receiver on the stack instead of putting nil on the stack
…e-bytes-but-certain-bytecodes-are-made-up-of-more-than-one-byte
…ly-skips-one-bytes-but-certain-bytecodes-are-made-up-of-more-than-one-byte Fixing skip so that it skips the right number of bytes to skip message send bytecodes
Fixing skip/skipUpTo commands so that they stop on return nodes, if they are implicit or not.
39 skip doesnt skip method nodes. Unrelated test failure.
…s-nor-step-block-creations
…ck-creations-nor-step-block-creations Fixing skip so that it skips block creations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.