Machine data caching#125
Merged
Merged
Conversation
…ruct and the data in a pointer didn't come with it.
grayside
approved these changes
Nov 18, 2017
Contributor
grayside
left a comment
grayside
left a comment
There was a problem hiding this comment.
Dang, I explored that but it never occurred to me that pass-by-value up the call chain would break it!
Would it be better to use the logger pattern of directly accessing the machine as a global?
Member
Author
|
The global pattern wouldn't make a different to this error, the fact that a single intermediary function call was not a pointer caused the copy. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moved to all pointer functions, as non-pointers make a copy of the struct and the data in a pointer didn't come with it.