Linux compatibility#99
Conversation
|
|
||
| const ( | ||
| dashboardContainerName string = "outrigger-dashboard" | ||
| dashboardImageName string = "outrigger/dashboard:latest" |
There was a problem hiding this comment.
I made these lower camel case to keep them as private constants. Do we have a use case to export them?
There was a problem hiding this comment.
Did not mean to make them public (by convention), was just looking at some approaches. i can revert that.
|
|
||
| func (cmd *Dashboard) Run(ctx *cli.Context) error { | ||
| if cmd.machine.IsRunning() { | ||
| if cmd.machine.IsRunning() || runtime.GOOS == "linux" { |
| } | ||
|
|
||
| func (cmd *DataBackup) Run(c *cli.Context) error { | ||
| if runtime.GOOS == "linux" { |
There was a problem hiding this comment.
Given the need to add runtime and check on Linux everywhere, I wonder if we shouldn't add a util/feature_detection.go now and define util.CanRunNative() as a check for linux.
There was a problem hiding this comment.
util.NativeDockerSupport() ?
There was a problem hiding this comment.
In anticipation of other things to detect, util.SupportsNativeDocker().
util.SupportsFileSync() would currently exclude windows without bash right?
|
|
||
| func (cmd *DataRestore) Run(c *cli.Context) error { | ||
| if runtime.GOOS == "linux" { | ||
| return cmd.Success("Data Restore is not needed on Linux, please unarchive any data directly") |
There was a problem hiding this comment.
This makes sense to me, but if we ever expanded on the data backup to include volume wrangling this would change.
grayside
left a comment
grayside
left a comment
There was a problem hiding this comment.
Looks good to me, just needs the go fmt fixup.
2 participants
No description provided.