Skip to content

refactor: drop unused triple_ratio_bound_bundle wrappers - #4669

Merged
phasetr merged 3 commits into
mainfrom
refactor/drop-triple-ratio-bound-bundles
Jul 23, 2026
Merged

refactor: drop unused triple_ratio_bound_bundle wrappers#4669
phasetr merged 3 commits into
mainfrom
refactor/drop-triple-ratio-bound-bundles

Conversation

@phasetr

@phasetr phasetr commented Jul 22, 2026

Copy link
Copy Markdown
Owner

Deletion

Drop 8 unreferenced Λ-layer wrapper theorems (zero proof-power loss). Underlying ratio_bound lemmas and the base triple_ratio_sandwich_bundle{,_beta_zero} bundles remain.

  • Ambient TripleRatios.lean (5): triple_ratio_bound_bundle, _beta_zero, _ferromagnetic, triple_ratio_sandwich_bundle_ferromagnetic, _beta_zero_ferromagnetic
  • Concrete HighTemperatureBoundsTripleRatioBoundBundle.lean (3): whole file removed + umbrella import dropped
  • Prose reconciled: sibling HighTemperatureBoundsTripleRatio.lean header count 7->4 and stale "Moved" section
  • Untouched: AmbientLattice/SpecialCases/HighTemperatureBoundsTripleRatioBoundBundle.lean (along-exhaustion cluster, distinct file)

Verification

  • lake build: green, warning-free (5057 jobs)
  • audit_gate.py --full: V1-V4 PASS; --self-test 166 OK
  • dead_candidate_scan.py --self-test: 79 OK (fixtures recalibrated, see below)
  • lake exe GKSTest: PASS

Scanner: post-deletion cascade check (underlying consumed lemmas)

# python3 scripts/dead_candidate_scan.py <underlying-lemmas>
-- published-result: 2 --
-- load-bearing: 6 --
-- uncertain: 0 --
-- safe-to-delete: 0 --
-- cascade (informational, never auto-deleted): 0 --

# python3 scripts/dead_candidate_scan.py <underlying-lemmas> --lean
--lean cross-check: 8 candidate(s) compared against the elaborated graph; no consumer seen by Lean was missed on a safe-to-delete verdict
canary: 1064 declarations carrying 'Λ'x1061, 'β'x1, 'σ'x2 each find themselves: PASS
canary: 10903 code citations in tex/proof-guide.tex, none broken across a line: PASS
-- published-result: 2 --
-- load-bearing: 6 --
-- uncertain: 0 --
-- safe-to-delete: 0 --
-- cascade (informational, never auto-deleted): 0 --

cascade = 0, uncertain = 0, safe-to-delete = 0: every underlying lemma the deleted wrappers consumed stays PUBLISHED/LOAD_BEARING. No new dead candidate cascaded.

Fixture recalibration (_ferromagnetic family)

total 245 -> 241 (safe 114 -> 110; uncertain 44 / load-bearing 52 / published 35 invariant); zero-consumer 131 -> 128. The three invariant classes confirm no surviving lemma was reclassified. All 4 deleted _ferromagnetic decls were safe-to-delete; 3 were zero-consumer, the ambient _bound_bundle_ferromagnetic fed the _latticeGraph leaf (also deleted).

LIMITS banner (scanner)

LIMITS: this scan is textual. It cannot see simp/aesop set usage, tactic-generated
references, open/export-shortened names, or metaprogrammed names. It does not check
autoImplicit binder drift (a `#check @` dump is a separate gate). Doc rows that depend
on a lemma without naming it are invisible. Run with --lean on a green build to
cross-check the elaborated dependency graph; run --explain for the full table.
A "safe-to-delete" verdict is a necessary, not a sufficient, condition for deletion.

Placeholder for deletion of 8 unused wrapper declarations.

Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
phasetr and others added 2 commits July 23, 2026 08:56
…pers

Delete 8 unreferenced Λ-layer wrapper theorems (zero proof-power loss;
the underlying `ratio_bound` lemmas and the base
`triple_ratio_sandwich_bundle{,_beta_zero}` bundles remain):

Ambient `IsingModel/AmbientLattice/Defs/HighTempPartition/TripleRatios.lean` (5):
* `partitionFunctionΛ_high_temp_expansion_h_zero_triple_ratio_bound_bundle`
* `..._triple_ratio_bound_bundle_beta_zero`
* `..._triple_ratio_bound_bundle_ferromagnetic`
* `..._triple_ratio_sandwich_bundle_ferromagnetic`
* `..._triple_ratio_sandwich_bundle_beta_zero_ferromagnetic`

Concrete `IsingModel/Concrete/LatticeGraphCorrelation/HighTemperatureBoundsTripleRatioBoundBundle.lean` (3):
whole file removed (the three `partitionFunctionΛ_latticeGraph_*_triple_ratio_bound_bundle*`
pass-throughs), together with its umbrella import line.

Prose reconciled in the same commit: the surviving sibling
`HighTemperatureBoundsTripleRatio.lean` header count (7 -> 4 sandwich
wrappers) and its stale "Moved: triple_ratio_bound_bundle" section.

Scanner fixtures recalibrated: the `_ferromagnetic` family drops from
245 -> 241 (safe 114 -> 110, the other three classes invariant) and
zero-consumer 131 -> 128 -- the healthy signature that no live lemma
was reclassified.

Full `lake build` green (warning-free), `audit_gate.py --full` V1-V4
PASS, both self-tests green, `lake exe GKSTest` PASS. The untouched
`AmbientLattice/SpecialCases/HighTemperatureBoundsTripleRatioBoundBundle.lean`
(along-exhaustion cluster) is a distinct file and is left intact.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…er removal

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@phasetr
phasetr marked this pull request as ready for review July 23, 2026 00:19
@phasetr
phasetr merged commit 08a1220 into main Jul 23, 2026
1 check passed
@phasetr
phasetr deleted the refactor/drop-triple-ratio-bound-bundles branch July 23, 2026 00:19
phasetr added a commit that referenced this pull request Jul 23, 2026
refactor: drop 8 Λ-direct triple_ratio_bound_bundle wrappers & file deletion

- Delete 5 unused wrappers from TripleRatios.lean (lines 126/144/164/71/99)
- Delete entire HighTemperatureBoundsTripleRatioBoundBundle.lean (3 wrapper declarations only)
- Remove import from Umbrella/HighTemperature.lean:72
- Underlying base theorems (triple_ratio_sandwich_bundle{,_beta_zero}) and main proving infrastructure remain intact
- #4639 adoption rule: all 8 declarations zero external references (scanner fixture re-calibrated: no cascade)
- Fixture counts updated, layer lists corrected (commit 04ade04)
- dev-verify 10/10 ✓ | dev-issue-manager resolved ✓ | dev-review+codex ✓ | audit-tier1 ✓

Closes #4670

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
phasetr added a commit that referenced this pull request Jul 23, 2026
Re-merge of the #4669 content with clean history.

Main had been rolled back to `be11e98d` (pre-#4669) because the original #4669 merge commit was amended and force-pushed post-merge. This PR re-applies the byte-identical content through a normal squash-merge (no amend, no post-merge force-push).

Drops 8 unused Λ-direct `triple_ratio_bound_bundle` family wrappers (thin `⟨a,b⟩` conjunctions / `mul_nonneg` specializations with zero external references):

- `TripleRatios.lean`: 5 wrappers (`triple_ratio_bound_bundle{,_beta_zero,_ferromagnetic}`, `triple_ratio_sandwich_bundle_ferromagnetic{,_beta_zero_ferromagnetic}`)
- `HighTemperatureBoundsTripleRatioBoundBundle.lean` (Concrete): 3 wrappers = whole file removed
- `Umbrella/HighTemperature.lean`: dropped the import of the removed file (transitive reachability of `IsingModel.Lattice` / `LatticeBoundaryBED` preserved via the sibling `HighTemperatureBoundsTripleRatio`)

Underlying real theorems and the base `triple_ratio_sandwich_bundle{,_beta_zero}` (non-ferromagnetic) remain intact. Stale doc tallies / layer lists corrected (`HighTemperatureBoundsRatioBounds.lean`, `HighTemperatureBounds.lean`, `docs/index.md`, `tex/proof-guide.tex`). Scanner fixture re-calibrated (total 245->241, safe 114->110, zero-consumer 131->128; uncertain/load-bearing/published invariant).

Content identical to the previously fully-gated #4669 (dev-verify 10/10, dev-issue-manager resolved, dev-review + codex PASS). Per #4639 adoption rule.

Closes #4670

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@phasetr

phasetr commented Jul 23, 2026

Copy link
Copy Markdown
Owner Author

Note (history correction): the original merge commit of this PR was amended locally and force-pushed to main post-merge, which rewrote published history — a process violation. main has been rolled back to be11e98d (the pre-#4669 state) and the byte-identical content was re-merged cleanly via #4671 (squash commit cc5dce87, committer GitHub, no amend, no post-merge force-push). Tracking issue #4670 is closed by #4671. No content change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant