Upgrade faraday#46
Closed
che-burashco wants to merge 2 commits into
Closed
Conversation
|
Encountering the same issue - phaxio's dependency on faraday < 2 is preventing us from using current versions of other gems. Please merge this! |
Contributor
|
Fixed in release v2.1.2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Faraday 2.0 has long been out however the gem has been locked to version being < 2.0. This is blocking us from being able to upgrade some of the gems in our repositories.
The upgrade guide that I followed can be found here.
What changed?
faraday-multipartas a dependency in gemspecfaraday-multipart, since it's not required by default anymoreNote
Despite the fact that
Faraday::UploadIOhas been deprecated in Faraday 2.0 in favor ofFaraday::FilePartI didn't have to change it in the code, sincefaraday-multiparttakes care of it here