Skip to content

fix fallback/stdio build#196

Merged
philburk merged 2 commits into
philburk:masterfrom
guberathome:stdio-build
Jan 20, 2025
Merged

fix fallback/stdio build#196
philburk merged 2 commits into
philburk:masterfrom
guberathome:stdio-build

Conversation

@guberathome

@guberathome guberathome commented Jan 5, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Fixes the build issue #195 on {MSYS2, Linux, FreeBSD, NetBSD}.

Test on Linux, FreeBSD are now ok:

$ IO_SOURCE="pf_io_stdio.c pf_fileio_stdio.c" make test
...
Standalone pForth executable written to pforth_standalone
cd ../../fth && /home/siggi/build/vanilla/pforth-2.0.1/platforms/unix/pforth_standalone -q t_corex.fth
...
 124 passed,    0 failed.
cd ../../fth && /home/siggi/build/vanilla/pforth-2.0.1/platforms/unix/pforth_standalone -q t_strings.fth
...
  58 passed,    0 failed.
cd ../../fth && /home/siggi/build/vanilla/pforth-2.0.1/platforms/unix/pforth_standalone -q t_locals.fth
...
   9 passed,    0 failed.
cd ../../fth && /home/siggi/build/vanilla/pforth-2.0.1/platforms/unix/pforth_standalone -q t_alloc.fth
...
   1 passed,    0 failed.
cd ../../fth && /home/siggi/build/vanilla/pforth-2.0.1/platforms/unix/pforth_standalone -q t_floats.fth
...
  60 passed,    0 failed.
cd ../../fth && /home/siggi/build/vanilla/pforth-2.0.1/platforms/unix/pforth_standalone -q t_file.fth
...
  94 passed,    0 failed.
PForth Tests PASSED

MSYS2 still fails on RESIZE-FILE.
Tests for FILE-RESIZE fails on NetBSD, which should probably be treated as separate issue.

@guberathome guberathome changed the title fix fallback/stdio build (#195) fix fallback/stdio build Jan 5, 2025
@guberathome guberathome marked this pull request as ready for review January 6, 2025 08:02
@guberathome

guberathome commented Jan 6, 2025

Copy link
Copy Markdown
Contributor Author

ready to be merged.

@guberathome

guberathome commented Jan 8, 2025

Copy link
Copy Markdown
Contributor Author

Update: Verify that this fixes the NetBSD problems as well after #198 has been merged.

@guberathome guberathome mentioned this pull request Jan 17, 2025
Open
philburk
philburk approved these changes Jan 20, 2025
View reviewed changes

@philburk philburk left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch.

Comment thread csrc/stdio/pf_io_stdio.c
@philburk philburk merged commit 9db4e9e into philburk:master Jan 20, 2025
@guberathome guberathome deleted the stdio-build branch January 22, 2025 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@philburk philburk philburk approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@guberathome @philburk