Bump supernote-typescript submodule to pick up link/keyword parsing - #121
Merged
Conversation
Brings in philips/supernote-typescript#24 (internal Supernote links and keyword stars, exported as ILink/sn.links and richer sn.keywords), needed by the keywords-to-tags and links-to-Wikilinks export feature split out of #81. No plugin-side code changes; this is purely the submodule pointer bump so that dependent feature branches have something to build on.
This was referenced Jul 27, 2026
philips
marked this pull request as ready for review
July 27, 2026 17:32
5 tasks
pull Bot
pushed a commit
to ben-vargas/supernote-obsidian-plugin
that referenced
this pull request
Jul 28, 2026
Closes philips#127. Buckets each page's ILink entries (from the link parsing merged in philips#121) and overlays a clickable, invisibly-positioned region for each LINKRECT, scaled/repositioned by the same mechanism that already keeps the pdf.js text layer aligned through zoom. Click handling resolves same-file links via PAGEID against the currently loaded pages, and cross-file links by basename against the vault (mirroring VaultWriter.resolvePageAnchor's export-time resolution from PR philips#122), reusing the existing #page=N ephemeral-state anchor for the cross-file page jump rather than inventing a new one. parseLinkRect/bucketLinksByPage live in a new obsidian-free module (src/linkOverlay.ts) so they're unit-testable, including a real-fixture test that verifies LINKRECT's coordinate space against actual parsed data rather than trusting it from a doc comment. Also fixes the vitest/eslint/tsc plumbing needed for a test to read a real .note file from disk (the first test in this repo to need any Node builtins).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Split out of #81 (by @Floper). Pure submodule pointer bump, no plugin-side code changes - bumps
supernote-typescriptto pick up philips/supernote-typescript#24 ("Parse Supernote internal links and keyword stars"), which addsILink/sn.linksand richersn.keywordsdata.This unblocks the keywords-to-tags and links-to-Wikilinks export feature (next PR in this stack), which needs those.
Test plan
npm run build- cleannpx vitest run- 22 passed