Support .mark file signatures (rebase of #8) - #30
Merged
Conversation
philips
marked this pull request as ready for review
July 27, 2026 01:47
Supernote digest exports use a "markSN_FILE_VER_" signature instead of "noteSN_FILE_VER_". Accept both so SupernoteX can parse .mark files exported from digest backups. Rebased from #8 (Tboules): carries forward the signature-parsing fix and the digest_test.mark fixture/test, dropped the incidental formatting, tsconfig, and dependency-version churn that had gone stale against current main.
philips-clanker
force-pushed
the
worktree-pr8-rebase
branch
from
July 27, 2026 01:48
541c6d1 to
3a1de1f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebases #8 by @Tboules onto current
main, which has diverged significantly since the PR was opened (typescript/eslint/vitest toolchain upgrades,colorv5, worker-parallel PDF rendering, etc).What's kept
src/parsing.ts:_parseSignaturenow acceptsmarkSN_FILE_VER_...in addition tonoteSN_FILE_VER_..., so digest exports (.markfiles) parse correctly.tests/input/digest_test.mark+ adigest_imagetest intests/main.test.tsexercisingtoImage()on a real digest-export.markfile, matching current test file conventions.What's dropped from #8
The original PR's diff was mostly incidental churn against a much older
main, all of which is now stale or superseded:tsconfig.jsontarget bump (es2016→es2018) — main is already ones2022.package.json@types/colorversion bump — main no longer depends on@types/colorat all (usescolor's ownColorInstancetype since v5).defaultPalette.backgroundchanged fromColor('transparent')toColor('white')— an unrelated behavior change to default rendering that main did not adopt; left astransparentto avoid a silent rendering regression.Verified:
npm run build,npm run lint, andnpx vitest runall pass (23/23 tests), including the newdigest_imagetest against the real.markfixture.Closes/supersedes #8.