Handle geolocation error messages - #761
Open
RaulBSanchez wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Change Summary
Updated
getUserLocationto return the browser geolocation error message instead ofnullwhen location access fails.Before:
After:
This allows the error message returned from the browser to be passed through the application.
Updated
UseMyLocationButton.tsxto use the returned value fromgetUserLocation.Before, all location errors displayed a hardcoded message:
After, the browser error message is passed to
onError:EstimatedWalkTime.tsxto store and display location error messages.Added state:
Changed:
to:
Change Reason
Previously, when geolocation failed, the application only tracked that an error occurred and displayed a generic message. The actual browser geolocation error message was not being used.
These changes allow the browser-provided error message to flow from
getUserLocation, throughUseMyLocationButton, and intoEstimatedWalkTime.tsx, where it can be displayed to the user.This provides clearer feedback when location permissions fail or location services are unavailable.
Verification [Optional]
Related Issue: #<732>