Skip to content

Conversation

@terabytesoftw
Copy link
Contributor

@terabytesoftw terabytesoftw commented Sep 29, 2025

Pull Request

Q A
Is bugfix? ✔️
New feature?
Breaks BC?

Summary by CodeRabbit

  • New Features
    • Added a configurable option to ignore Composer platform requirements across CI workflows, improving flexibility when running checks and tests.
    • Introduced a selectable operating system input for the ECS workflow to broaden environment coverage.
  • Documentation
    • Updated the changelog to note the new workflow inputs and related improvements.

@terabytesoftw terabytesoftw added the bug Something isn't working label Sep 29, 2025
@coderabbitai
Copy link

coderabbitai bot commented Sep 29, 2025

Walkthrough

Adds a new boolean workflow_call input ignore-platform-reqs (default false) to multiple GitHub Actions workflows and threads it into the “Setup PHP Environment” step. Adds an os input to the ECS workflow. Updates CHANGELOG with an entry documenting these changes.

Changes

Cohort / File(s) Summary of changes
Composer ignore-platform-reqs input propagation
.github/workflows/codeception.yml, .github/workflows/composer-require-checker.yml, .github/workflows/infection.yml, .github/workflows/phpstan.yml, .github/workflows/phpunit.yml, .github/workflows/phpunit-database.yml
Added workflow_call input ignore-platform-reqs: boolean (default: false) and passed it to the “Setup PHP Environment” step via with: ignore-platform-reqs: ${{ inputs.ignore-platform-reqs }}.
ECS workflow input extension
.github/workflows/ecs.yml
Added workflow_call input os with description, default, required flag, and type.
Changelog update
CHANGELOG.md
Added v2.0.5 “Under development” entry noting Bug #68: addition of ignore-platform-reqs input across workflows.

Sequence Diagram(s)

sequenceDiagram
    autonumber
    actor Caller as Caller Workflow/Job
    participant Reusable as Reusable Workflow (workflow_call)
    participant Setup as Setup PHP Environment Action
    participant Composer as Composer

    Caller->>Reusable: Call workflow with inputs<br/>ignore-platform-reqs (bool)
    Reusable->>Setup: with ignore-platform-reqs=${{ inputs.ignore-platform-reqs }}
    Setup->>Composer: Run install/update<br/>(--ignore-platform-reqs when true)
    Composer-->>Setup: Exit status
    Setup-->>Reusable: Step result
    Reusable-->>Caller: Workflow result
    Note over Setup,Composer: Flag controls Composer platform requirement checks
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Poem

A nibble of flags in the burrow of YAML,
I twitch my nose—Composer won’t make a scandal.
Flip a boolean, hop past platform checks,
Pipelines purr with silky specs.
New OS crumbs for ECS to chase—
Changelog carrots neatly in place. 🥕

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title concisely describes the primary change, namely adding the ignore-platform-reqs input to multiple workflow files. It follows conventional commit style by specifying the scope (workflows) and the nature of the fix. This phrasing is specific enough to convey the main intent without extraneous detail.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix-mini-47

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e616f1c and 6e93949.

📒 Files selected for processing (8)
  • .github/workflows/codeception.yml (2 hunks)
  • .github/workflows/composer-require-checker.yml (2 hunks)
  • .github/workflows/ecs.yml (1 hunks)
  • .github/workflows/infection.yml (2 hunks)
  • .github/workflows/phpstan.yml (2 hunks)
  • .github/workflows/phpunit-database.yml (2 hunks)
  • .github/workflows/phpunit.yml (2 hunks)
  • CHANGELOG.md (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: linter / Super Linter
  • GitHub Check: linter / Super Linter
🔇 Additional comments (3)
.github/workflows/phpstan.yml (1)

57-61: Input ignore-platform-reqs verified
The ignore-platform-reqs input is defined in php-setup/action.yml (lines 41–42) and correctly handled by checking for 'true' in the action logic (lines 106–107).

.github/workflows/codeception.yml (1)

57-61: Verified ignore-platform-reqs support and no duplicate flags
The php-setup action.yml defines ignore-platform-reqs as a boolean input and the workflows correctly pass it; the default composer-flags don’t include --ignore-platform-reqs, so no duplication.

.github/workflows/composer-require-checker.yml (1)

47-51: All workflows consistently define and pass ignore-platform-reqs, and the php-setup action supports it. No changes needed.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@terabytesoftw terabytesoftw merged commit c6e8eff into main Sep 29, 2025
13 checks passed
@terabytesoftw terabytesoftw deleted the fix-mini-47 branch September 29, 2025 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants