update string comparisons possible returns.#1857
Merged
Merged
Conversation
cmb69
reviewed
Oct 4, 2022
Member
cmb69
left a comment
cmb69
left a comment
There was a problem hiding this comment.
Thanks for the PR!
All affected functions would need changelog entries; it probably makes sense to define an XML entity for that.
devnexen
force-pushed
the
strcmp_ret_changes
branch
2 times, most recently
from
e30f5ec to
766f562
Compare
devnexen
force-pushed
the
strcmp_ret_changes
branch
from
766f562 to
84387c2
Compare
Member
|
I pushed a commit with the missing changelog entries; I guess the wording can be improved. What do you think, @devnexen? |
Member
Author
|
thanks @cmb69 looks ok to me |
Member
|
So I'm going to commit. :) |
tiffany-taylor
pushed a commit
to tiffany-taylor/doc-en
that referenced
this pull request
Jan 16, 2023
Co-authored-by: Christoph M. Becker <cmbecker69@gmx.de> Closes phpGH-1857.
claudepache
pushed a commit
to claudepache/php-doc-en
that referenced
this pull request
Jun 1, 2023
Co-authored-by: Christoph M. Becker <cmbecker69@gmx.de> Closes phpGH-1857.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.