Skip to content

Updates for RFC: Locale-independent case conversion#1934

Merged
Girgias merged 3 commits into
php:masterfrom
tstarling:strtolower-ascii
Nov 7, 2022
Merged

Updates for RFC: Locale-independent case conversion#1934
Girgias merged 3 commits into
php:masterfrom
tstarling:strtolower-ascii

Conversation

@tstarling
Copy link
Copy Markdown
Contributor

  • Add a detailed description of what is meant by ASCII case conversion to strtolower() and strtoupper().
  • Replace locale-related text on ucfirst(), lcfirst() and ucwords() with text about ASCII case conversion.
  • Remove entity note.locale-single-byte since it was only used on ucwords().
  • Add changelog entries to all the functions mentioned in the RFC.

* Add a detailed description of what is meant by ASCII case conversion
  to strtolower() and strtoupper().
* Replace locale-related text on ucfirst(), lcfirst() and ucwords()
  with text about ASCII case conversion.
* Remove entity note.locale-single-byte since it was only used on
  ucwords().
* Add changelog entries to all the functions mentioned in the RFC.
Comment thread reference/array/constants.xml Outdated
Comment thread reference/array/constants.xml Outdated
Comment thread reference/array/constants.xml Outdated
Comment thread reference/strings/functions/lcfirst.xml Outdated
tstarling and others added 2 commits November 4, 2022 23:19
Co-authored-by: George Peter Banyard <girgias@php.net>
Copy link
Copy Markdown
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@Girgias Girgias merged commit 54ff7bf into php:master Nov 7, 2022
claudepache pushed a commit to claudepache/php-doc-en that referenced this pull request Jun 1, 2023
* Add a detailed description of what is meant by ASCII case conversion
  to strtolower() and strtoupper().
* Replace locale-related text on ucfirst(), lcfirst() and ucwords()
  with text about ASCII case conversion.
* Remove entity note.locale-single-byte since it was only used on
  ucwords().
* Add changelog entries to all the functions mentioned in the RFC.

Co-authored-by: George Peter Banyard <girgias@php.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants