WIP: fixing slow cgi mode#837
Closed
withinboredom wants to merge 2 commits into
Closed
Conversation
Member
|
Good start! Maybe could we get rid of the thread pooling library and just start a fixed number of threads by ourself (each thread will consume the same channel, as you started to implement). |
Member
Author
|
FYI: this hasn't been forgotten. My wife has had surgery, and I've been doing daddy + day job. She should be recovered in the next two weeks or so. |
Member
|
Good luck to your wife and you! There is no urgency. I can take a look if you want. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is currently VERY draft-state.
Goals:
This PR intends to start a number of threads that handle non-worker requests. Like FPM/worker mode, it reuses the PHP context from the previous request to cut down on latency.
fixes #836