Fix unused variable in pdo_sqlite_stmt_set_attribute()#18851
Merged
Conversation
The indentation is also wrong (using spaces instead of tabs), but this should be fixed in a separate commit.
devnexen
approved these changes
Jun 14, 2025
TimWolla
approved these changes
Jun 14, 2025
| return 0; | ||
| } | ||
|
|
||
| pdo_sqlite_stmt *S = (pdo_sqlite_stmt*)stmt->driver_data; |
Member
There was a problem hiding this comment.
The cast is also not necessary here.
Suggested change
| pdo_sqlite_stmt *S = (pdo_sqlite_stmt*)stmt->driver_data; | |
| pdo_sqlite_stmt *S = stmt->driver_data; |
Member
Author
There was a problem hiding this comment.
Technically not, but casting void* is somewhat of a personal preference. It's there for all other usages of driver_data in this file, so we should probably stay consistent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The indentation is also wrong (using spaces instead of tabs), but this should be fixed in a separate commit.
See https://github.com/php/php-src/actions/runs/15647022368/job/44086182043