Fix GH-15796: Add the exit_status() function#19445
Conversation
bb9e345 to
3b124ed
Compare
3b124ed to
df352ca
Compare
df352ca to
22a19ee
Compare
TimWolla
left a comment
There was a problem hiding this comment.
Implementation LGTM, but given this is a feature, I've requested reviews from the RMs.
DanielEScherzer
left a comment
There was a problem hiding this comment.
Given the lack of an RFC for this addition, or even a mailing list discussion, the RMs are not comfortable with adding it to PHP 8.5 given the feature freeze.
Marking this as "Request changes" to make it clear that this shouldn't be merged until after PHP 8.5 is branched at the earliest
|
Friendly ping on this one, now that PHP 8.5 has been branched |
|
I think it would be good to mention it on internal and describe the use case a bit more. If there are no objections, I think it can be merged. |
|
I don't see an option to remove my "requested changes", maybe because of the merge conflict? |
I suppose so, normally the option to dismiss a review is at the bottom. You can rerequest your own review though which I think will also clear the status. |
|
Just getting back to this one. I'll mention it on the mailing list as soon as I can, as requested by Jakub. |
Fix #15796
Especially useful in shutdown handler, allows to get the current exit status code if set by an exit statement.